You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/08 10:01:53 UTC
[GitHub] [pulsar] Pomelongan opened a new pull request, #17969: [cleanup][broker]remove methods no longer used in AdminResource #7
Pomelongan opened a new pull request, #17969:
URL: https://github.com/apache/pulsar/pull/17969
### Motivation
`org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadataCheckAllowAutoCreation` and `org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadata` are no longer used.
### Modifications
remove `org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadataCheckAllowAutoCreation` and `org.apache.pulsar.broker.admin.AdminResource#fetchPartitionedTopicMetadata`.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/Pomelongan/pulsar/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #17969: [cleanup][broker]remove methods no longer used in AdminResource #7
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17969:
URL: https://github.com/apache/pulsar/pull/17969#issuecomment-1272302959
Please check the unused import, such as `import org.apache.pulsar.broker.PulsarService;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #17969: [cleanup][broker]remove methods no longer used in AdminResource #7
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #17969:
URL: https://github.com/apache/pulsar/pull/17969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Pomelongan commented on pull request #17969: [cleanup][broker]remove methods no longer used in AdminResource #7
Posted by GitBox <gi...@apache.org>.
Pomelongan commented on PR #17969:
URL: https://github.com/apache/pulsar/pull/17969#issuecomment-1272435754
> Please check the unused import, such as `import org.apache.pulsar.broker.PulsarService;`
I have updated it.PTAL @HQebupt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org