You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by ji...@apache.org on 2020/10/08 23:46:44 UTC

[geode] branch support/1.13 updated: GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596) - spotless

This is an automated email from the ASF dual-hosted git repository.

jinmeiliao pushed a commit to branch support/1.13
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/support/1.13 by this push:
     new 443aef9  GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596) - spotless
443aef9 is described below

commit 443aef9e9a1d2b5eaf5db8db68785bfabf4a724b
Author: Jinmei Liao <ji...@pivotal.io>
AuthorDate: Thu Oct 8 16:45:03 2020 -0700

    GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596) - spotless
    
    (cherry picked from commit 73f6783b07f1151c1617978fb57822ade5b71414)
---
 .../internal/api/LocatorClusterManagementService.java | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java b/geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
index 3ada781..309a775 100644
--- a/geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
+++ b/geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
@@ -45,7 +45,6 @@ import org.apache.geode.annotations.VisibleForTesting;
 import org.apache.geode.cache.execute.Execution;
 import org.apache.geode.cache.execute.Function;
 import org.apache.geode.cache.execute.FunctionService;
-import org.apache.geode.cache.execute.ResultCollector;
 import org.apache.geode.distributed.DistributedMember;
 import org.apache.geode.distributed.internal.InternalConfigurationPersistenceService;
 import org.apache.geode.internal.cache.InternalCache;
@@ -205,11 +204,11 @@ public class LocatorClusterManagementService implements ClusterManagementService
 
     ClusterManagementRealizationResult result = new ClusterManagementRealizationResult();
 
-      // execute function on all targeted members
-      List<RealizationResult> functionResults = executeCacheRealizationFunction(
-          config, CacheElementOperation.CREATE,
-          targetedMembers);
-      functionResults.forEach(result::addMemberStatus);
+    // execute function on all targeted members
+    List<RealizationResult> functionResults = executeCacheRealizationFunction(
+        config, CacheElementOperation.CREATE,
+        targetedMembers);
+    functionResults.forEach(result::addMemberStatus);
 
     // if any false result is added to the member list
     if (result.getStatusCode() != StatusCode.OK) {
@@ -302,10 +301,10 @@ public class LocatorClusterManagementService implements ClusterManagementService
     // execute function on all members
     ClusterManagementRealizationResult result = new ClusterManagementRealizationResult();
 
-      List<RealizationResult> functionResults = executeCacheRealizationFunction(
-          config, CacheElementOperation.DELETE,
-          memberValidator.findServers(groupsWithThisElement));
-      functionResults.forEach(result::addMemberStatus);
+    List<RealizationResult> functionResults = executeCacheRealizationFunction(
+        config, CacheElementOperation.DELETE,
+        memberValidator.findServers(groupsWithThisElement));
+    functionResults.forEach(result::addMemberStatus);
 
     // if any false result is added to the member list
     if (result.getStatusCode() != StatusCode.OK) {