[jira] [Comment Edited] (UNOMI-119) pastEventCondition hardcoded 5000 limit

["Don Hinshaw (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/UNOMI-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132179#comment-16132179 ] 

Don Hinshaw edited comment on UNOMI-119 at 8/18/17 1:32 PM:
------------------------------------------------------------

Serge,

Thanks for your response.  I have no problem doing this change myself, I will have it done shortly.

Should I simply create a feature branch and make a PR in GitHub?

Do you recall why you changed the limit to 5000 in the first place? Was there an issue with long queries before?


was (Author: donald_kortx):
Serge,

Thanks for your response.  I have no problem doing this change myself, I will have it done shortly.

Do you recall why you changed the limit to 5000 in the first place? Was there an issue with long queries before?

> pastEventCondition hardcoded 5000 limit
> ---------------------------------------
>
>                 Key: UNOMI-119
>                 URL: https://issues.apache.org/jira/browse/UNOMI-119
>             Project: Apache Unomi
>          Issue Type: Improvement
>            Reporter: Don Hinshaw
>            Priority: Minor
>
> https://<host>/cxs/query/profile/count
> {code}
> {
>     "type": "pastEventCondition",
>     "parameterValues": {
>     	"eventCondition" : {
>     		"type" : "matchAllCondition",
>     		"parameterValues" : {
>     		}
>     	},
>     	"numberOfDays" : 7
>     }
> }
> {code}
> in ElasticSearchPersistenceServiceImpl.java like 1485 there is a hardcoded limit of 5000.
> {code}bucketsAggregation = AggregationBuilders.terms("buckets").field(aggregate.getField()).size(5000);{code}
> This change was made on December 5 in commit 96a018ecb1b5b907930504e69f6da9357db8385e
> I think this value should be configurable.  The way it is now, we are unable to get the count when our query has more that 5000 results.
> Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)