You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by "Jaideep Dhok (JIRA)" <ji...@apache.org> on 2015/04/02 11:45:53 UTC
[jira] [Commented] (LENS-473) Change the queryable field validation
logic
[ https://issues.apache.org/jira/browse/LENS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392460#comment-14392460 ]
Jaideep Dhok commented on LENS-473:
-----------------------------------
Test output
{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.089s]
[INFO] Lens .............................................. SUCCESS [2.208s]
[INFO] Lens API .......................................... SUCCESS [6.020s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.323s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.696s]
[INFO] Lens DB storage ................................... SUCCESS [10.405s]
[INFO] Lens Query Library ................................ SUCCESS [4.606s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:32.247s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.433s]
[INFO] Lens Server ....................................... SUCCESS [4:27.310s]
[INFO] Lens client ....................................... SUCCESS [20.454s]
[INFO] Lens CLI .......................................... SUCCESS [2:36.307s]
[INFO] Lens Examples ..................................... SUCCESS [0.885s]
[INFO] Lens Distribution ................................. SUCCESS [10.056s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:02.609s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.534s]
[INFO] Lens Regression ................................... SUCCESS [0.477s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:24.529s
[INFO] Finished at: Thu Apr 02 09:23:08 UTC 2015
[INFO] Final Memory: 110M/1124M
[INFO] ------------------------------------------------------------------------
{noformat}
> Change the queryable field validation logic
> -------------------------------------------
>
> Key: LENS-473
> URL: https://issues.apache.org/jira/browse/LENS-473
> Project: Apache Lens
> Issue Type: Improvement
> Components: cube
> Affects Versions: 2.1
> Reporter: Amareshwari Sriramadasu
> Priority: Critical
> Fix For: 2.1
>
> Attachments: lens-473.patch
>
>
> Right now the field validation logic at https://github.com/apache/incubator-lens/blob/master/lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java#L103 does the following :
> It gets all the dim-attributes queried and measures queried in the user query (after expressions are expanded), then it finds if there is single derived cube having all the attributes queried and any of measures queried. And makes sure all the measures queried are covered by attribute covering derived cubes. For chain attributes, it picks source columns of chains as the dim-attributes in the above validate.
> Instead it should do the following :
> * Do validation only when query has aggregates
> * Pick dim-attributes (or chain ref columns) only if they are not part of aggregate expression.
> * Above mentioned logic of attribute covering and measuring covering logic would be the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)