You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/15 02:52:49 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #1236: Move mallinfo from stdlib.h to malloc.h

yamt opened a new pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236


   mallinfo is meant to be API compatible with Linux,
   where it's provided by malloc.h.
   Make stdlib.h include malloc.h for now, until all users
   are updated.
   
   (I think the API actually originated with System V. I don't remember
   how it was there though.  Anyway, I guess the compatibility with Linux
   is more important than System V these days.)
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo merged pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643892648


   If this is the right thing to do, the I would prefer that we do it right the first time.  Let's please not put the kludge in stdlib.h.  How would we ever know when to remove it?  That just dirties the header files.
   
   Let's instead make a clean break and add malloch.h to every file that references mallinfo.  Isn't that the correct thing to do?  If so, let's do it right!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643898159


   @patacongo i did this way because nuttx and apps patches can't be merged atomically.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643923773


   @patacongo i pushed a change to break the build as you suggested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-643875012


   See https://github.com/apache/incubator-nuttx/issues/1235 for the nxstyle complaint


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-644095998


   I don't think that is a good reason.  We have faced this in the past and were able to get things straightened out.  The PR checks have to be ignored in the case, unfortunately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1236: Move mallinfo from stdlib.h to malloc.h

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1236:
URL: https://github.com/apache/incubator-nuttx/pull/1236#issuecomment-644096573


   We'll deal with after the 9.1 branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org