You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AchimGaedkeLynker (via GitHub)" <gi...@apache.org> on 2024/01/18 20:29:46 UTC
[PR] Run Trigger Page: Configurable number of recent configs [airflow]
AchimGaedkeLynker opened a new pull request, #36878:
URL: https://github.com/apache/airflow/pull/36878
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Some users are heavily relying on running DAGs manually by altering or repeating previous configurations.
The number (more precisely limit) of previous runs sent to the `trigger.html` selector is 5 and quite low for this use-case.
This PR makes the number of recent DAG run configurations configurable.
Questions:
* Are there any unit tests required here?
* I (speaking for the in house users) would love that feature sooner than later, I've put version 2.9.0 into the configuration YML, I believe that's the earliest when sticking to semantic versioning... and the change is liked by the airflow community...
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run Trigger Page: Configurable number of recent configs [airflow]
Posted by "AchimGaedkeLynker (via GitHub)" <gi...@apache.org>.
AchimGaedkeLynker commented on PR #36878:
URL: https://github.com/apache/airflow/pull/36878#issuecomment-1900080278
Screenshot as requested - it is the number of entries in the "Select Recent Configurations" dropdown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run Trigger Page: Configurable number of recent configs [airflow]
Posted by "AchimGaedkeLynker (via GitHub)" <gi...@apache.org>.
AchimGaedkeLynker commented on PR #36878:
URL: https://github.com/apache/airflow/pull/36878#issuecomment-1900074186
I'd be really happy getting advice on unit tests, figuring out the test/CI setup for each project is always daunting.
This PR seems to have a decent example for unit-testing configurations. - @dirrao , what's your take?
https://github.com/apache/airflow/pull/35460/files#diff-603905684cc5476d24f0294f961251bbb9852f881803c52bedaeb220a82db11d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Run Trigger Page: Configurable number of recent configs [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #36878:
URL: https://github.com/apache/airflow/pull/36878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org