[GitHub] [sling-feature-launcher-maven-plugin] rombert commented on a change in pull request #1: SLING-10374 optionally wait for user input before stopping the server

[GitBox <gi...@apache.org>]

rombert commented on a change in pull request #1:
URL: https://github.com/apache/sling-feature-launcher-maven-plugin/pull/1#discussion_r629950467



##########
File path: src/main/java/org/apache/sling/maven/feature/launcher/StopMojo.java
##########
@@ -37,9 +39,20 @@
     @Component
     private ProcessTracker processes;
     
+    /**
+     * If {@code true} stopping the server is deferred until you press the Enter key.
+     */
+    @Parameter(property = "feature-launcher.waitForInput", required = false, defaultValue = "false")
+    protected boolean waitForInput;
+
+    @Component
+    private Prompter prompter;
+
     @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
-        
+        if (waitForInput) {

Review comment:
       Can we make this conditional of being executed in an interactive mode? Then the error message for when the prompt fails could be cleared.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org