You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/02 14:30:15 UTC

[GitHub] [airflow] kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call

kpathak13 commented on a change in pull request #6237: AIRFLOW-5581: Join KubernetesJobWatcher in terminate call
URL: https://github.com/apache/airflow/pull/6237#discussion_r330583452
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -576,6 +576,7 @@ def _labels_to_key(self, labels):
     def terminate(self):
         """Termninates the watcher."""
         self.watcher_queue.join()
+        self.kube_watcher.join()
 
 Review comment:
   Correct me if I am wrong @ashb, I believe this call [self.processor_agent.terminate()](https://github.com/apache/airflow/blob/master/airflow/jobs/scheduler_job.py#L1434) signals the `manager` to terminate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services