You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/07 14:26:15 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #14895: [fix](nereids)add slot desc for order key

morrySnow commented on code in PR #14895:
URL: https://github.com/apache/doris/pull/14895#discussion_r1042270725


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -487,6 +488,24 @@ public PlanFragment visitPhysicalTopN(PhysicalTopN<? extends Plan> topN, PlanTra
         return mergeFragment;
     }
 
+    private List<OrderKey> addAliasForNonSlot(List<OrderKey> orderKeys) {

Review Comment:
   i think, we do not need to re-generate orderKey list. just mod generateTupleDesc to generate slot for non-SlotReference key is enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org