You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/18 02:29:59 UTC
[GitHub] [druid] junegunn opened a new pull request #10774: "druid.request.logging.type" should allow "noop" value
junegunn opened a new pull request #10774:
URL: https://github.com/apache/druid/pull/10774
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
### Description
We should be able to set `druid.request.logging.type` to `noop` as [documented](https://druid.apache.org/docs/latest/configuration/index.html#request-logging).
> Caused by: com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Could not resolve type id 'noop' as a subtype of `org.apache.druid.server.log.RequestLoggerProvider`: known type ids = [composing, emitter, file, filtered, slf4j, switching]
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `QueryableModule`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10774: "druid.request.logging.type" should allow "noop" value
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10774:
URL: https://github.com/apache/druid/pull/10774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] junegunn edited a comment on pull request #10774: "druid.request.logging.type" should allow "noop" value
Posted by GitBox <gi...@apache.org>.
junegunn edited a comment on pull request #10774:
URL: https://github.com/apache/druid/pull/10774#issuecomment-770729568
We only enable request logger for the brokers, so `noop` for the other components. I'm aware that `noop` logger is the default so we can just omit `druid.request.logging.type` entry in the config files if we want it. But we accidentally found this problem while writing our Ansible templates.
```jinja
# What we tried
druid.request.logging.type={{ historical_request_logging_type }}
```
To workaround the issue, we have to rewrite it like so:
```jinja
{% if historical_request_logging_type != 'noop' %}
druid.request.logging.type={{ historical_request_logging_type }}
{% endif %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] junegunn commented on pull request #10774: "druid.request.logging.type" should allow "noop" value
Posted by GitBox <gi...@apache.org>.
junegunn commented on pull request #10774:
URL: https://github.com/apache/druid/pull/10774#issuecomment-770729568
We only enable request logger for the brokers, so `noop` for the other components. I'm aware that `noop` logger is the default so we can just omit `druid.request.logging.type` entry in the config files if we want it. But we accidentally found this problem while writing our Ansible templates.
```jinja
# What we tried
druid.request.logging.type={{ historical_request_logging_type }}
# To workaround the issue, we have to rewrite it like so
{% if historical_request_logging_type != 'noop' %}
druid.request.logging.type={{ historical_request_logging_type }}
{% endif %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org