You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/31 16:55:07 UTC

[GitHub] [spark] dbtsai commented on a change in pull request #27066: [SPARK-22231][SQL] Add withField method to Column class

dbtsai commented on a change in pull request #27066: [SPARK-22231][SQL] Add withField method to Column class
URL: https://github.com/apache/spark/pull/27066#discussion_r401067377
 
 

 ##########
 File path: python/pyspark/sql/column.py
 ##########
 @@ -303,6 +303,25 @@ def getItem(self, key):
         """
         return _bin_op("getItem")(self, key)
 
+    @ignore_unicode_prefix
+    @since(3.0)
 
 Review comment:
   It will be 3.1 since it's too late for 3.0. Can we remove the python part in this PR, and focus on merging the core Scala part?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org