[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4284: php test performance

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4284:
URL: https://github.com/apache/netbeans/pull/4284#discussion_r906825974


##########
ide/parsing.indexing/src/org/netbeans/modules/parsing/impl/indexing/PathRegistry.java:
##########
@@ -68,7 +68,7 @@
 public final class PathRegistry implements Runnable {
 
     private static final boolean FIRE_UNKNOWN_ALWAYS = false;
-    /*test*/ static final int FIRER_EVT_COLLAPSE_WINDOW = 500;
+    /*test*/ static int FIRER_EVT_COLLAPSE_WINDOW = 500;

Review Comment:
   Suggestion: Set this from a system property (Full classname + Fieldname?) and default to 500. That way the field can be kept static final and there is no need to twiddle with accessibility of the field.



##########
nbbuild/templates/projectized.xml:
##########
@@ -290,7 +290,7 @@
     <target name="test-lib-init" depends="-init-bootclasspath-prepend,init,-build-libs.junit4">
         <path id="test.unit.lib.cp"/>
         <property name="test.jms.flags" value=""/>
-        <property name="test.run.args" value="-ea -Xmx700m ${metabuild.jms-flags.jvm} ${test.jms.flags} -XX:+IgnoreUnrecognizedVMOptions"/>
+        <property name="test.run.args" value="-ea -Xms1200m -Xmx1200m -XX:+UseParallelGC ${metabuild.jms-flags.jvm} ${test.jms.flags} -XX:+IgnoreUnrecognizedVMOptions"/>

Review Comment:
   Everytime I see people mess with the GC I have to ask this: Is there a measurable improvement switching from G1GC to ParallelGC and does it depend on the JVM version? Pinning the heapsize in my mind is ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists