You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "myandpr (via GitHub)" <gi...@apache.org> on 2024/01/06 19:11:35 UTC
[PR] [#974] fix: Dynamic remote storage conf invalid [incubator-uniffle]
myandpr opened a new pull request, #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424
<!--
1. Title: [#974 ] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
Fix: #974
### Does this PR introduce _any_ user-facing change?
Before:
`rss.coordinator.remote.storage.cluster.conf hadoop-ns01,dfs.hosts=a,b,c,dfs.service=sssss`
will trigger a bug.
After:
`rss.coordinator.remote.storage.cluster.conf hadoop-ns01,dfs.hosts=a,b,c,dfs.service=sssss`
will work correctly.
Yes.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#974] fix: Dynamic remote storage conf invalid [incubator-uniffle]
Posted by "myandpr (via GitHub)" <gi...@apache.org>.
myandpr commented on PR #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424#issuecomment-1879791304
Hi @zuston , I am new here, would you take a look at this bug fix PR? Many thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#974] fix(coordinator): Dynamic remote storage conf invalid for `LegacyClientConfParser` [incubator-uniffle]
Posted by "myandpr (via GitHub)" <gi...@apache.org>.
myandpr commented on PR #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424#issuecomment-1880338776
> Welcome to uniffle community! @myandpr
Thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#974] fix(coordinator): Dynamic remote storage conf invalid for `LegacyClientConfParser` [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424#issuecomment-1880338126
Welcome to uniffle community! @myandpr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#974] fix: Dynamic remote storage conf invalid [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424#issuecomment-1879931218
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `2 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`15a399a`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/15a399ac2a67632913384863bf8457ed18c0da65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.43% compared to head [(`4720301`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.64%.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/uniffle/coordinator/util/CoordinatorUtils.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvdXRpbC9Db29yZGluYXRvclV0aWxzLmphdmE=) | 90.00% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1424 +/- ##
============================================
+ Coverage 53.43% 53.64% +0.21%
+ Complexity 2723 2199 -524
============================================
Files 419 342 -77
Lines 23992 15420 -8572
Branches 2046 1424 -622
============================================
- Hits 12820 8272 -4548
+ Misses 10378 6686 -3692
+ Partials 794 462 -332
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1424?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#974] fix(coordinator): Dynamic remote storage conf invalid for `LegacyClientConfParser` [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1424:
URL: https://github.com/apache/incubator-uniffle/pull/1424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org