You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2024/08/13 07:59:33 UTC
[PR] [bugfix]:keep the incrementally compiled version time updated [nuttx]
xuxin930 opened a new pull request, #12903:
URL: https://github.com/apache/nuttx/pull/12903
## Summary
when building incrementally, the ustname time information is wrong.
this patch fix phoney target mismatch issue, always rebuild ustname.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bugfix] keep the incrementally compiled version time updated [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #12903:
URL: https://github.com/apache/nuttx/pull/12903#discussion_r1714904224
##########
libs/libc/misc/CMakeLists.txt:
##########
@@ -112,4 +112,10 @@ if(CONFIG_FDCHECK)
list(APPEND SRCS lib_fdcheck.c)
endif()
+add_custom_target(
Review Comment:
Should we check `CONFIG_LIBC_UNAME_DISABLE_TIMESTAMP` before add dependencies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bugfix] keep the incrementally compiled version time updated [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #12903:
URL: https://github.com/apache/nuttx/pull/12903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [bugfix] keep the incrementally compiled version time updated [nuttx]
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on code in PR #12903:
URL: https://github.com/apache/nuttx/pull/12903#discussion_r1714928333
##########
libs/libc/misc/CMakeLists.txt:
##########
@@ -112,4 +112,10 @@ if(CONFIG_FDCHECK)
list(APPEND SRCS lib_fdcheck.c)
endif()
+add_custom_target(
Review Comment:
> Should we check `CONFIG_LIBC_UNAME_DISABLE_TIMESTAMP` before add dependencies?
sure, completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org