You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by oarap <gi...@git.apache.org> on 2016/09/09 00:51:17 UTC
[GitHub] incubator-hawq pull request #896: [#126526845] Port recent changes from gpdb...
GitHub user oarap opened a pull request:
https://github.com/apache/incubator-hawq/pull/896
[#126526845] Port recent changes from gpdb for hawq
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsyuan/incubator-hawq 126526845_port_newest_orca
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #896
----
commit fce7f9ed0ca8e1a42b6b60ef4b1cbdb94c873d96
Author: Haisheng Yuan and Omer Arap <hy...@pivotal.io>
Date: 2016-09-09T00:47:24Z
[#126526845] Port recent changes from gpdb for hawq
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
Hi @hsyuan, could you help me to open a apache jira, and change the commit log with "HAWQ-XXX. titile'? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
Reverted for a lot of test failed. 2 kind of reasons already found:
1) error/warning msg changed by this commit.
2) some queries' plan changed by orca.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
@oarap thanks for the update. @liming01 and @paul-guo-, please review the port.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #896: [#126526845] Port recent changes from gpdb...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by oarap <gi...@git.apache.org>.
Github user oarap commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
@huor the PR description is updated. Thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
@hsyuan, it would be great if there are more descriptive information regarding the change here and thus the impact. It would help the reviewer to understand more with this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
ping, any updates on the review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by vraghavan78 <gi...@git.apache.org>.
Github user vraghavan78 commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
@paul-guo- is it a simple move or re-write?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
I'd suggest moving the test cases to src/test/feature (googletest framework) in this change or in other changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
@liming01 Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #896: [#126526845] Port recent changes from gpdb for ha...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/896
It is not a simple move. It is kind of rewrite sql&output into cpp test classes.
Since this PR is just porting, we can do it in later changes.
@liming01 Can you merge this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---