You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by drexin <gi...@git.apache.org> on 2014/07/09 21:52:31 UTC
[GitHub] spark pull request: use mesos slaveId concatenated with mesos exec...
GitHub user drexin opened a pull request:
https://github.com/apache/spark/pull/1348
use mesos slaveId concatenated with mesos executorId as executorId
Mesos executor ids are only unique on a per-node basis, therefore
we have to include the slave id in the spark executor id
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drexin/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1348
----
commit 4f63f9ea55411e6122229ab199cb865a28ebff4f
Author: Dario Rexin <da...@r3-tech.de>
Date: 2014-07-09T19:49:11Z
use mesos slaveId concatenated with mesos executorId as executorId
Mesos executor ids are only unique on a per-node basis, therefore
we have to include the slave id in the spark executor id
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: use mesos slaveId concatenated with mesos exec...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1348#issuecomment-48525974
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: use mesos slaveId concatenated with mesos exec...
Posted by drexin <gi...@git.apache.org>.
Github user drexin commented on the pull request:
https://github.com/apache/spark/pull/1348#issuecomment-48531500
This does not seem to solve the issue. Will reopen the PR once I'm sure the problem has been fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: use mesos slaveId concatenated with mesos exec...
Posted by drexin <gi...@git.apache.org>.
Github user drexin closed the pull request at:
https://github.com/apache/spark/pull/1348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---