You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/11/23 23:00:51 UTC
Review Request 69438: Skipped an rlimit test if the environment is
incompatible.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69438/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9397
https://issues.apache.org/jira/browse/MESOS-9397
Repository: mesos
Description
-------
Skipped an rlimit test if the environment is incompatible.
Diffs
-----
src/tests/containerizer/posix_rlimits_isolator_tests.cpp 3af00446255a3f5480834db67aa6d4c428526ac3
Diff: https://reviews.apache.org/r/69438/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 69438: Skipped an rlimit test if the environment is
incompatible.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69438/#review210835
-----------------------------------------------------------
Ship it!
src/tests/containerizer/posix_rlimits_isolator_tests.cpp
Lines 138-142 (patched)
<https://reviews.apache.org/r/69438/#comment295595>
Thanks, that will help others to understand the failure before going through debug-hell :)
- Till Toenshoff
On Nov. 23, 2018, 11 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69438/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2018, 11 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9397
> https://issues.apache.org/jira/browse/MESOS-9397
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Skipped an rlimit test if the environment is incompatible.
>
>
> Diffs
> -----
>
> src/tests/containerizer/posix_rlimits_isolator_tests.cpp 3af00446255a3f5480834db67aa6d4c428526ac3
>
>
> Diff: https://reviews.apache.org/r/69438/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 69438: Skipped an rlimit test if the environment is
incompatible.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69438/#review210837
-----------------------------------------------------------
PASS: Mesos patch 69438 was successfully built and tested.
Reviews applied: `['67136', '69438']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2641/mesos-review-69438
- Mesos Reviewbot Windows
On Nov. 24, 2018, midnight, Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69438/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2018, midnight)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9397
> https://issues.apache.org/jira/browse/MESOS-9397
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Skipped an rlimit test if the environment is incompatible.
>
>
> Diffs
> -----
>
> src/tests/containerizer/posix_rlimits_isolator_tests.cpp 3af00446255a3f5480834db67aa6d4c428526ac3
>
>
> Diff: https://reviews.apache.org/r/69438/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>