You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/25 08:00:38 UTC

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1907: feat: Use monaco editor

liuxiran commented on a change in pull request #1907:
URL: https://github.com/apache/apisix-dashboard/pull/1907#discussion_r638548774



##########
File path: web/package.json
##########
@@ -19,15 +19,15 @@
     "lint:style": "stylelint --fix \"src/**/*.less\" --syntax less",
     "prettier": "prettier -c --write \"**/*\"",
     "site": "yarn run fetch:blocks && yarn run build",
-    "start": "umi dev",
-    "start:e2e": "cross-env SERVE_ENV=test umi dev",
+    "start": "cp -R ./node_modules/monaco-editor ./public/ && umi dev",

Review comment:
       HI @qian0817 , may I ask why we need to cp `monaco-editor` to `./public`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org