You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2014/04/02 19:12:11 UTC
[jclouds-labs-openstack] Backport OS Neutron Extension Router (#88)
You can merge this Pull Request by running:
git pull https://github.com/rackerlabs/jclouds-labs-openstack backport-router
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-openstack/pull/88
-- Commit Summary --
* OS Neutron Extension Router
-- File Changes --
M openstack-neutron/pom.xml (1)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/NeutronApi.java (8)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/ExternalGatewayInfo.java (105)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Network.java (2)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/NetworkType.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Port.java (4)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Router.java (151)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/RouterInterface.java (127)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/domain/Subnet.java (10)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApi.java (217)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/PortApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApi.java (13)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseNetworkDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseNetworks.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParsePortDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParsePorts.java (6)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseRouterDetails.java (93)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseRouters.java (93)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseSubnetDetails.java (6)
M openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/functions/ParseSubnets.java (6)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/CreateRouterOptions.java (168)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/EmptyOptions.java (48)
A openstack-neutron/src/main/java/org/jclouds/openstack/neutron/v2_0/options/UpdateRouterOptions.java (168)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApiExpectTest.java (295)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/extensions/RouterApiLiveTest.java (192)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/NetworkApiLiveTest.java (8)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/PortApiLiveTest.java (25)
M openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/features/SubnetApiLiveTest.java (23)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/parse/ParseRouterTest.java (55)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/util/ClassUtil.java (43)
A openstack-neutron/src/test/java/org/jclouds/openstack/neutron/v2_0/util/PredicateUtil.java (51)
A openstack-neutron/src/test/resources/list_routers.json (74)
A openstack-neutron/src/test/resources/router.json (7)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-openstack/pull/88.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/88.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Zack Shoylev <no...@github.com>.
This should probably also be part of the larger neutron refactoring anyways.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39380443
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39504664
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Everett Toews <no...@github.com>.
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39452754
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Andrew Phillips <no...@github.com>.
> However these should be addresses with separate PRs in master first (instead of modifying this PR). Agree?
+1 to that, and good with this PR. Thanks, @zack-shoylev!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39656742
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #198](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/198/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39357748
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-openstack #1001](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/1001/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39357811
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Zack Shoylev <no...@github.com>.
Closed #88.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88
Re: [jclouds-labs-openstack] Backport OS Neutron Extension Router
(#88)
Posted by Zack Shoylev <no...@github.com>.
These changes make sense to me. However these should be addresses with separate PRs in master first (instead of modifying this PR). Agree?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/88#issuecomment-39380385