You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by dneuman64 <gi...@git.apache.org> on 2017/04/26 19:12:30 UTC
[GitHub] incubator-trafficcontrol pull request #522: [TC-255] and [TC-256] -- Fixes i...
GitHub user dneuman64 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/522
[TC-255] and [TC-256] -- Fixes issues with removed method and inability to add a DS w/o a profile
This fixes the following issues:
[TC-255](https://issues.apache.org/jira/browse/TC-255) - Cannot manage SSL certs for DSs that don't already have certs.
[TC-256](https://issues.apache.org/jira/browse/TC-256) - Connot add a DS without a profile.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dneuman64/incubator-trafficcontrol to_fix_cdn_domain_method
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #522
----
commit 7c13dbcf4e96d33aa9ce10bf50698910bc4cffee
Author: David Neuman <da...@gmail.com>
Date: 2017-04-26T19:09:20Z
Update Dnsseckeys.pm and Sslkeys.pm to no longer us get_cdn_domain method. This fixes TC-255
commit 7760368af34e536e59b8c0f4be1cff5cc1016a7b
Author: David Neuman <da...@gmail.com>
Date: 2017-04-26T19:10:04Z
Fixes the ability to add a DS without a profile. This fixes TC-256
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by mitchell852 <gi...@git.apache.org>.
Github user mitchell852 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
for this error:
column reference "id" is ambiguous so change that query to
my $profile = $self->db->resultset('Profile')->search( { 'me.id' => $profile_id }
^^ me.id
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dg4prez <gi...@git.apache.org>.
Github user dg4prez commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
I'm able to create a new delivery service without a profile, and I'm able to generate ssl keys, but when I take an existing DS and attempt to set it from http to https, I get the following error:
[2017-05-02 12:00:39,044] [DEBUG] Routing to controller "UI::DeliveryService" and action "update".
[2017-05-02 12:00:42,264] [ERROR] Can't call method "cdn" on an undefined value at /home/dgelin200/incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 585.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
ok, I'll take a look at that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol pull request #522: [TC-255] and [TC-256] -- Fixes i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafficcontrol/pull/522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
@mitchell852 That error is coming from `/incubator-trafficcontrol/traffic_ops/app/lib/UI/DnssecKeys.pm line 242` which I did not change in my PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
not certain I'm doing it right, but trying to test the manage ssl certs, I hit this error: ```Traffic Ops fatal error occurred while processing your request.
Error at line 242 ( my $profile = $self->db->resultset('Profile')->search( { id => $profile_id }, { prefetch => ['cdn'] } )->single();)
DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::Pg::st execute failed: ERROR: column reference "id" is ambiguous LINE 1: ...e me LEFT JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL... ^ [for Statement "SELECT me.id, me.name, me.description, me.last_updated, me.type, me.cdn, cdn.id, cdn.name, cdn.last_updated, cdn.dnssec_enabled, cdn.domain_name FROM profile me LEFT JOIN cdn cdn ON cdn.id = me.cdn WHERE ( id IS NULL )"] at /home/dkirkw202/incubator-trafficcontrol/traffic_ops/app/lib/UI/DnssecKeys.pm line 242```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
@dangogh I could not reproduce the issue with manage ssl certs, can you give me a little more context? I tried an existing DS that didn't have SSL keys already, a new DS, and a DS that already had keys and all three use cases worked.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dneuman64 <gi...@git.apache.org>.
Github user dneuman64 commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
I do see the issue with not providing a host regex. However, I think that is outside the scope of this PR and should be logged as a new issue resulting in a new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafficcontrol issue #522: [TC-255] and [TC-256] -- Fixes issues w...
Posted by dangogh <gi...@git.apache.org>.
Github user dangogh commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/522
and for the DS without a profile, I failed to put in a regex and got a crash rather than an error popup:
```Traffic Ops fatal error occurred while processing your request.
Error at line 28 ($morbo->run($app);)
Please supply a host regular expression at .../incubator-trafficcontrol/traffic_ops/app/lib/MojoPlugins/DeliveryService.pm line 178.
....
called at .../incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 385
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---