You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bilgin Ibryam (JIRA)" <ji...@apache.org> on 2007/07/24 10:49:31 UTC
[jira] Created: (OFBIZ-1171) Adding rental products to quotes
Adding rental products to quotes
--------------------------------
Key: OFBIZ-1171
URL: https://issues.apache.org/jira/browse/OFBIZ-1171
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Hi guys,
Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
Regards,
- Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514967 ]
Hans Bakker commented on OFBIZ-1171:
------------------------------------
Perhaps a littlebit background,
The rental data model is described in the data model resource book volume 2 starting on page 264.
The current implementation is only covering the asset_usage product type which is storing a number of fields in the product entity which only are active with this product type. The book is calling this a 'Hotel offering'
A quote is not mentioned in the book for reservations (orders)
Other product types can be easily added with or without their own tables.
David, can you tell me why you see a need to rethink this?
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517775 ]
Bilgin Ibryam commented on OFBIZ-1171:
--------------------------------------
Thanks for answering Hans.
You can only check rental.patch, it is the newer and full patch. Please ignore the quote.patch (Next time i will use the same name for the patch, so it will replace the old one)
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514980 ]
Jacques Le Roux commented on OFBIZ-1171:
----------------------------------------
Hans,
Thanks for this valuable info. I will buy this book finally !
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1171) Adding rental products to quotes
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hans Bakker reassigned OFBIZ-1171:
----------------------------------
Assignee: Hans Bakker
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515264 ]
Bilgin Ibryam commented on OFBIZ-1171:
--------------------------------------
David, thank you for giving me a chance to share my "rental" requirements ;)
It is absolutely true that current code supporting room rentals is very limited and a more general and flexible data model would be great. For now it is possible only to do a reservation from ecommerce application for the whole day and only if the capacity of the fixed asset is still available. These are all the possibilities.
In the reality there are needs like (I have needs like)
1) "overbooking" a room for example. It is something usual to do overbooking when you are sure that some of the reservations will be canceled. There could be a flag on fixed asset allowing or not overbooking.
2) Another needed feature is so called "waiting list". When a room is reserved, you can put a customer reservations on a waiting list. Canceling reservations is something very common and after canceling a reservation (or you got a free room some reason), you can take from the waiting list another customer and to make an order. (Actually I was planning to implement the waiting list like quotes, because currently there is no other way to temporarily save a rental order when fixed asset is not available).
3) Doing a request->quote->order(reservation) is another not yet implemented feature that is very often used in travel industry.
4) Canceling reservations happens all the time. This a very basic need in this industry! For now it is not possible to cancel a reservation in ofbiz. You can cancel it but the fixed asset calendar still shows the fixed asset like reserved and you cannot do another reservation. Editing the dates of reservation is not supported also.It is possible someone to free the room earlier or to stay longer...
5) Marking a fixed asset like "in repair" status and then doing it not available for reservations (while in this status).
6)Invoicing for rental orders is broken. To get the invoice you have to ship the order, but if it is a rental product you get an error and the invoice is not available.
These are only some of the features that i can guess now (and I have to implement very soon).
Another very big drawback is that it is not possible to make reservations for some hours (1, 3, 6, 12...) like in car or boat renting. For now all the reservations are from 24:00 to 24:00 next day. Even in hotel offering it is something usual someone to leave the room some hours earlier and it should be possible to mark the room as available, without waiting till 24:00:00 for doing the next reservation. But for now i do not know how could it be done :(
I'd like to implement(or participate in implementing) some(all) of the features mentioned above and commit it back to ofbiz, but need feedback and guidance from the community especially for data model improvements. I think that these features will help a lot to people willing to use ofbiz in travel(rental) industry.
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514997 ]
Bilgin Ibryam commented on OFBIZ-1171:
--------------------------------------
In the data model resource book i have, hotel offerings are on page 364 not 264 ;)
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1171) Adding rental products to quotes
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hans Bakker closed OFBIZ-1171.
------------------------------
Resolution: Fixed
Hi Bilgin,
your patch is now in revision 566181. Thanks for the help.
Hans
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517529 ]
Bilgin Ibryam commented on OFBIZ-1171:
--------------------------------------
David, Hans and all,
I would like to hear Your opinion about the points above and rental products future directions at all.
Do you think that some of them are needed and could be useful addition to ofbiz ?
Also i did another patch, that allows:
1) Adding a rental product to request.
2)Adding a rental product to quote.
3)Creating an order from quote with rental products.
4)Create a new order from existing order having rental products.
Soon i will take a look at some of the problems mentioned in my previous post
Regards,
Bilgin Ibryam
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517682 ]
Hans Bakker commented on OFBIZ-1171:
------------------------------------
Hi Bilgin,
The additions you ask for, are justified, no problem. Up to now however we did not yet have a requirement from a customer to do otherwise. Most changes in OFBiz are user driven as you perhaps know.
I will check your patches and will commit them in the next few days.
Regards,
Hans
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1171) Adding rental products to quotes
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514929 ]
David E. Jones commented on OFBIZ-1171:
---------------------------------------
This is an interesting issue because it opens a rather interesting can of worms.
I say this because the current model and code supporting room rentals is fairly limited and only meets a fairly specific set of requirements, and not really all that flexible for other organizations that have different requirements.
That said, while this is an interesting change I wonder if it might be a good time to do a little requirements sharing and solicitation so can come up with a more general data model that will be sufficiently flexible for more of the foreseeable future.
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1171:
---------------------------------
Attachment: quote.patch
the patch
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1171) Adding rental products to quotes
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1171:
---------------------------------
Attachment: rental.patch
the patch
> Adding rental products to quotes
> --------------------------------
>
> Key: OFBIZ-1171
> URL: https://issues.apache.org/jira/browse/OFBIZ-1171
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: quote.patch, rental.patch
>
>
> Hi guys,
> Currently it is possible to add rental products to cart and then to create a quote from cart. But while creating quotes from cart we lost some rental product specific data (like reservation start day, number of days and number of persons). Then if we try to create order from quote we get error (because of the lost rental data). So the quote become useless. I added 3 new columns to quoteItem entity (reservStart, reservLength, reservPersons) and did very small changes. Now it is possible to create order from a quote with rental products.
> Regards,
> - Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.