You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 10:54:09 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #10336:
[FLINK-14935][task, runtime] Use RunnableWithException in the Mailbox
pnowojski commented on a change in pull request #10336: [FLINK-14935][task,runtime] Use RunnableWithException in the Mailbox
URL: https://github.com/apache/flink/pull/10336#discussion_r352532423
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/Mail.java
##########
@@ -61,11 +62,7 @@ public String toString() {
return String.format(descriptionFormat, descriptionArgs);
}
- public void run() {
- try {
- runnable.run();
- } catch (Exception e) {
- throw new IllegalStateException("Cannot process mail " + toString(), e);
Review comment:
Ok, I see.
Btw, clearly this try/catch and `toString` was missing a test coverage
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services