[impala] 02/04: IMPALA-8114: Deflake test_breakpad.py

[jb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jbapple pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit b3318ad434f1a82a880afeaf600233ea76e8ca0f
Author: Lars Volker <lv...@cloudera.com>
AuthorDate: Thu Jan 24 17:15:15 2019 -0800

    IMPALA-8114: Deflake test_breakpad.py
    
    A test failed recently in a private build and it looked like the loop in
    wait_for_num_processes had terminated to early. To make sure that the
    forked of processes that write the minidumps have actually started, we
    now sleep for 1 second before entering the wait loop.
    
    Change-Id: Ifcd1fbb498c475a1f186f490abaf90b47ecba05b
    Reviewed-on: http://gerrit.cloudera.org:8080/12273
    Reviewed-by: Tim Armstrong <ta...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/custom_cluster/test_breakpad.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/custom_cluster/test_breakpad.py b/tests/custom_cluster/test_breakpad.py
index ff7aa12..0726a2b 100644
--- a/tests/custom_cluster/test_breakpad.py
+++ b/tests/custom_cluster/test_breakpad.py
@@ -308,7 +308,10 @@ class TestBreakpadExhaustive(TestBreakpadBase):
     # enough files to trigger rotation.
     for i in xrange(max_minidumps + 1):
       self.kill_cluster(SIGUSR1)
-      # Breakpad forks to write its minidump files, wait for all the clones to terminate.
+      # Breakpad forks to write its minidump files, sleep briefly to allow the forked
+      # processes to start.
+      time.sleep(1)
+      # Wait for all the clones to terminate.
       assert self.wait_for_num_processes('impalad', cluster_size) == cluster_size
       assert self.wait_for_num_processes('catalogd', 1) == 1
       assert self.wait_for_num_processes('statestored', 1) == 1