Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

[Christian Carlow <ch...@gmail.com>]

PortalPageViewPermissionError occurs for users of SUPER group if not.
Also PortalPageViewPermissionError has no UiLabelMap entry for
translations.  Are these issues worth JIRAs?

Re: Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

[Adrian Crum <ad...@sandglass-software.com>]

There is no consistency within the community regarding how to 
announce/propose/commit changes, so it is probably best to use overkill 
and do as much as possible to document the change - no matter how trivial.

For example, I announced I was going to fix a startup problem in OFBiz 
(a trivial change), and I was asked to create a Jira issue beforehand so 
others can review it. Conversely, Jacopo recently refactored encryption 
(a change with considerable impact) and no announcement/Jira 
issue/review was done beforehand.

So, there is no real "policy" about the change workflow - instead, it 
depends on the community's perception of the committer and what that 
committer feels they can get away with.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 6/14/2015 1:29 AM, Jacques Le Roux wrote:
> Pierre, Christian,
>
> I think Christian asked because I recently told him in a Jira that our
> way of doing is to discuss main points here before creating Jiras.
>
> Of course this recommendation applies only to main points. Like
> replacing all *.fo.ftl files by widget as Christian recently suggested
> by creating a Jira w/o prior discussion here.
> I guess, it needs some time to discern some main points, but most are
> obvious. For instance those below are not changing much OFBiz, so Jiras
> could be created w/o prior discussion.
>
> Also why Jiras need to be created might need to be clarified. We use
> Jira to automatically generate our change logs.
> So in theory each changes should have a Jira, but maybe not a simple
> label change for instance... At the end it all about common sense, our
> community can help when we are undecided...
>
> Jira
>
> Le 13/06/2015 19:19, Pierre Smits a écrit :
>> Hi Christian,
>>
>> Any bug, or improvement is worthy of its own issue.
>>
>> Best regards,
>>
>> Pierre.
>>
>> On Saturday, June 13, 2015, Christian Carlow <ch...@gmail.com>
>> wrote:
>>
>>> PortalPageViewPermissionError occurs for users of SUPER group if not.
>>> Also PortalPageViewPermissionError has no UiLabelMap entry for
>>> translations.  Are these issues worth JIRAs?
>>>
>>>

Re: Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

[Christian Carlow <ch...@gmail.com>]

Thanks for the clarification Jacques.

OFBIZ-6400 was updated to handle this if PORTALPAGE_ADMIN should remain
a permission.

On Sun, 2015-06-14 at 10:29 +0200, Jacques Le Roux wrote:
> Pierre, Christian,
> 
> I think Christian asked because I recently told him in a Jira that our way of doing is to discuss main points here before creating Jiras.
> 
> Of course this recommendation applies only to main points. Like replacing all *.fo.ftl files by widget as Christian recently suggested by creating a 
> Jira w/o prior discussion here.
> I guess, it needs some time to discern some main points, but most are obvious. For instance those below are not changing much OFBiz, so Jiras could be 
> created w/o prior discussion.
> 
> Also why Jiras need to be created might need to be clarified. We use Jira to automatically generate our change logs.
> So in theory each changes should have a Jira, but maybe not a simple label change for instance... At the end it all about common sense, our community 
> can help when we are undecided...
> 
> Jira
> 
> Le 13/06/2015 19:19, Pierre Smits a écrit :
> > Hi Christian,
> >
> > Any bug, or improvement is worthy of its own issue.
> >
> > Best regards,
> >
> > Pierre.
> >
> > On Saturday, June 13, 2015, Christian Carlow <ch...@gmail.com>
> > wrote:
> >
> >> PortalPageViewPermissionError occurs for users of SUPER group if not.
> >> Also PortalPageViewPermissionError has no UiLabelMap entry for
> >> translations.  Are these issues worth JIRAs?
> >>
> >>

Re: Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

[Jacques Le Roux <ja...@les7arts.com>]

Pierre, Christian,

I think Christian asked because I recently told him in a Jira that our way of doing is to discuss main points here before creating Jiras.

Of course this recommendation applies only to main points. Like replacing all *.fo.ftl files by widget as Christian recently suggested by creating a 
Jira w/o prior discussion here.
I guess, it needs some time to discern some main points, but most are obvious. For instance those below are not changing much OFBiz, so Jiras could be 
created w/o prior discussion.

Also why Jiras need to be created might need to be clarified. We use Jira to automatically generate our change logs.
So in theory each changes should have a Jira, but maybe not a simple label change for instance... At the end it all about common sense, our community 
can help when we are undecided...

Jira

Le 13/06/2015 19:19, Pierre Smits a écrit :
> Hi Christian,
>
> Any bug, or improvement is worthy of its own issue.
>
> Best regards,
>
> Pierre.
>
> On Saturday, June 13, 2015, Christian Carlow <ch...@gmail.com>
> wrote:
>
>> PortalPageViewPermissionError occurs for users of SUPER group if not.
>> Also PortalPageViewPermissionError has no UiLabelMap entry for
>> translations.  Are these issues worth JIRAs?
>>
>>

Re: Shouldn't PORTALPAGE_ADMIN be part of SUPER group permissions?

[Pierre Smits <pi...@gmail.com>]

Hi Christian,

Any bug, or improvement is worthy of its own issue.

Best regards,

Pierre.

On Saturday, June 13, 2015, Christian Carlow <ch...@gmail.com>
wrote:

> PortalPageViewPermissionError occurs for users of SUPER group if not.
> Also PortalPageViewPermissionError has no UiLabelMap entry for
> translations.  Are these issues worth JIRAs?
>
>

-- 
Pierre Smits

*ORRTIZ.COM <http://www.orrtiz.com>*
Services & Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail & Trade
http://www.orrtiz.com