[GitHub] [netbeans] asbachb commented on a diff in pull request #6140: Bugfix: Added ability to find `jakarta` related jars for wildfly server instances

["asbachb (via GitHub)" <gi...@apache.org>]

asbachb commented on code in PR #6140:
URL: https://github.com/apache/netbeans/pull/6140#discussion_r1257522289


##########
enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/util/WildFlyProperties.java:
##########
@@ -232,12 +232,16 @@ private List<URL> selectJars(FileObject file) {
     }
 
     public List<URL> getClasses() {
-        List<URL> list = selectJars(FileUtil.toFileObject(new File(getModulePath("javax"))));
+        List<URL> classes = new ArrayList<>();
+
+        classes.addAll(selectJars(FileUtil.toFileObject(new File(getModulePath("jakarta")))));
+        classes.addAll(selectJars(FileUtil.toFileObject(new File(getModulePath("javax")))));

Review Comment:
   Afaik there's no release providing both namespaces and if the module is not found it's not added (that's what happened before when you add a new wildfly with jakarta namespace) - So the only thing I can imagine this might cause problems is when both apis are provided by wildfly/jboss eap. I slightly remember that there was some time where both namespaces were supported, but I think I remember that was done via some custom `ClassLoader`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists