You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2021/11/11 16:47:37 UTC

[tomcat] branch main updated: Move GPG check to deploy-release target

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new b59e88c  Move GPG check to deploy-release target
b59e88c is described below

commit b59e88c985c008530705a70d950cc9ef1033c495
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Nov 11 16:47:24 2021 +0000

    Move GPG check to deploy-release target
    
    This allows snapshots to continue without GPG
---
 res/maven/mvn-pub.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
index 6671de1..f74a40e 100644
--- a/res/maven/mvn-pub.xml
+++ b/res/maven/mvn-pub.xml
@@ -502,6 +502,7 @@
   </target>
 
   <target name="deploy-release">
+    <fail unless="gpg.exec.available">GPG is required, but was not found at ${gpg.exec}</fail>
     <antcall target="generic-deploy">
       <param name="maven.repo.repositoryId"
              value="${maven.asf.release.repo.repositoryId}"/>
@@ -515,7 +516,6 @@
 
   <target name="init-gpg-1">
     <available file="${gpg.exec}" property="gpg.exec.available"/>
-    <fail unless="gpg.exec.available">GPG is required, but was not found at ${gpg.exec}</fail>
   </target>
 
   <target name="init-gpg-2" if="${gpg.exec.available}">

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [tomcat] branch main updated: Move GPG check to deploy-release target

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

On 11/11/21 11:47, markt@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> 
> 
> The following commit(s) were added to refs/heads/main by this push:
>       new b59e88c  Move GPG check to deploy-release target
> b59e88c is described below
> 
> commit b59e88c985c008530705a70d950cc9ef1033c495
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Thu Nov 11 16:47:24 2021 +0000
> 
>      Move GPG check to deploy-release target
>      
>      This allows snapshots to continue without GPG

Ooh, sorry about that. Thanks for moving this.

I was trying to get the failure as close to the beginning of the build 
as possible, so minimize the amount of time required to detect it and 
fix it. The Maven build takes like 5 minutes on my computer so I 
generally let it go in the background while I do other things.

-chris

> ---
>   res/maven/mvn-pub.xml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
> index 6671de1..f74a40e 100644
> --- a/res/maven/mvn-pub.xml
> +++ b/res/maven/mvn-pub.xml
> @@ -502,6 +502,7 @@
>     </target>
>   
>     <target name="deploy-release">
> +    <fail unless="gpg.exec.available">GPG is required, but was not found at ${gpg.exec}</fail>
>       <antcall target="generic-deploy">
>         <param name="maven.repo.repositoryId"
>                value="${maven.asf.release.repo.repositoryId}"/>
> @@ -515,7 +516,6 @@
>   
>     <target name="init-gpg-1">
>       <available file="${gpg.exec}" property="gpg.exec.available"/>
> -    <fail unless="gpg.exec.available">GPG is required, but was not found at ${gpg.exec}</fail>
>     </target>
>   
>     <target name="init-gpg-2" if="${gpg.exec.available}">
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org