You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/14 10:36:19 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in
pull request #69: mksymtab.sh: Avoid using find -executable
xiaoxiang781216 commented on a change in pull request #69: mksymtab.sh: Avoid using find -executable
URL: https://github.com/apache/incubator-nuttx-apps/pull/69#discussion_r379360494
##########
File path: examples/elf/tests/mksymtab.sh
##########
@@ -22,7 +22,7 @@ fi
# Extract all of the undefined symbols from the ELF files and create a
# list of sorted, unique undefined variable names.
-varlist=`find ${dir} -executable -type f | xargs nm | fgrep ' U ' | sed -e "s/^[ ]*//g" | cut -d' ' -f2 | sort | uniq`
Review comment:
Can we merge the similar script into one:
apps/tools/mksymtab.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services