You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/01/05 18:34:26 UTC
Review Request 41935: Added persistent volume HTTP endpoint
authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41935/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
Bugs: MESOS-3903
https://issues.apache.org/jira/browse/MESOS-3903
Repository: mesos
Description
-------
Added persistent volume HTTP endpoint authorization.
Diffs
-----
src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110
src/tests/persistent_volume_endpoints_tests.cpp c0feedee393b8475fd27b0af9344d306a392893e
Diff: https://reviews.apache.org/r/41935/diff/
Testing
-------
`make check` was used to test.
New tests were added to the persistent volume endpoint tests which exercise the authorization features in a variety of scenarios.
Thanks,
Greg Mann
Re: Review Request 41935: Added persistent volume HTTP endpoint
authorization.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41935/#review112975
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41935/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 5:34 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added persistent volume HTTP endpoint authorization.
>
>
> Diffs
> -----
>
> src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110
> src/tests/persistent_volume_endpoints_tests.cpp c0feedee393b8475fd27b0af9344d306a392893e
>
> Diff: https://reviews.apache.org/r/41935/diff/
>
>
> Testing
> -------
>
> `make check` was used to test.
>
> New tests were added to the persistent volume endpoint tests which exercise the authorization features in a variety of scenarios.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 41935: Added persistent volume HTTP endpoint
authorization.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41935/#review112924
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41934, 41935]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 5, 2016, 5:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41935/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 5:34 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added persistent volume HTTP endpoint authorization.
>
>
> Diffs
> -----
>
> src/master/http.cpp deb0c8f9852dc0eec1e8c0ff35c684f982e8b110
> src/tests/persistent_volume_endpoints_tests.cpp c0feedee393b8475fd27b0af9344d306a392893e
>
> Diff: https://reviews.apache.org/r/41935/diff/
>
>
> Testing
> -------
>
> `make check` was used to test.
>
> New tests were added to the persistent volume endpoint tests which exercise the authorization features in a variety of scenarios.
>
>
> Thanks,
>
> Greg Mann
>
>