You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "eurecalulu (via GitHub)" <gi...@apache.org> on 2023/09/05 07:52:55 UTC
[GitHub] [shenyu-dashboard] eurecalulu opened a new pull request, #335: fix: fix the bug of changing the state during the render process and other small bugs
eurecalulu opened a new pull request, #335:
URL: https://github.com/apache/shenyu-dashboard/pull/335
This pr mainly fixes some bugs:
1. In our current code, the state is changed in the render function, thus causing the following warning：
In addition, too much data processing should be avoided in the render function, otherwise performance will be affected. Therefore, I extracted the data processing part of the menus and the calling part of the reducer in the render method as a function.
2. When setting the inline style of an element, change the hyphen naming convention to the camel naming convention.
3. Comment out some redundant code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu-dashboard] moremind merged pull request #335: fix: fix the bug of changing the state during the render process and other small bugs
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind merged PR #335:
URL: https://github.com/apache/shenyu-dashboard/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org