[GitHub] [incubator-druid] fstolba commented on a change in pull request #8857: Add reference to druid.storage.type

[GitBox <gi...@apache.org>]

fstolba commented on a change in pull request #8857: Add reference to druid.storage.type
URL: https://github.com/apache/incubator-druid/pull/8857#discussion_r345460456
 
 

 ##########
 File path: docs/development/extensions-core/s3.md
 ##########
 @@ -61,6 +63,7 @@ As an example, to set the region to 'us-east-1' through system properties:
 |`druid.storage.sse.type`|Server-side encryption type. Should be one of `s3`, `kms`, and `custom`. See the below [Server-side encryption section](#server-side-encryption) for more details.|None|
 |`druid.storage.sse.kms.keyId`|AWS KMS key ID. This is used only when `druid.storage.sse.type` is `kms` and can be empty to use the default key ID.|None|
 |`druid.storage.sse.custom.base64EncodedKey`|Base64-encoded key. Should be specified if `druid.storage.sse.type` is `custom`.|None|
+|`druid.storage.type`|Global deep storage provider. Must be set to `s3` to make use of this extension.|`local`| 
 
 Review comment:
   Yes that probably makes sense to just mark it as mandatory. We could suggest people might want to use `s3` considering the page they're viewing.
   Regarding the table ordering it looks like the knobs are grouped at least by their namespace so I put it with the other `druid.storage` parameters. Seeing that the first paragraph in the Configuration section mentions that this knob is mandatory it seems to me one would be able to quickly grasp the importance of this parameter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org