You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/09 03:32:26 UTC
Review Request 37263: Add support for non-subscribe HTTP calls in the
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37263/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-2293
https://issues.apache.org/jira/browse/MESOS-2293
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa
src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
Diff: https://reviews.apache.org/r/37263/diff/
Testing
-------
make check
No new tests yet: The plan is to write tests once we update the scheduler library to HTTP.
Thanks,
Vinod Kone
Re: Review Request 37263: Add support for non-subscribe HTTP calls in
the master.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37263/#review94657
-----------------------------------------------------------
Ship it!
LGTM !
- Anand Mazumdar
On Aug. 9, 2015, 1:32 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37263/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 1:32 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-2293
> https://issues.apache.org/jira/browse/MESOS-2293
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
>
> Diff: https://reviews.apache.org/r/37263/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet: The plan is to write tests once we update the scheduler library to HTTP.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37263: Add support for non-subscribe HTTP calls in
the master.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37263/#review94658
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37263]
All tests passed.
- Mesos ReviewBot
On Aug. 9, 2015, 1:32 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37263/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 1:32 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-2293
> https://issues.apache.org/jira/browse/MESOS-2293
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
>
> Diff: https://reviews.apache.org/r/37263/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet: The plan is to write tests once we update the scheduler library to HTTP.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 37263: Add support for non-subscribe HTTP calls in
the master.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37263/#review94768
-----------------------------------------------------------
src/master/http.cpp (lines 396 - 398)
<https://reviews.apache.org/r/37263/#comment149364>
We should probably log this as well? How about 'Framework is not SUBSCRIBED' since this is going back to the user now rather than only sitting in our logs.
- Ben Mahler
On Aug. 9, 2015, 1:32 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37263/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2015, 1:32 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Ben Mahler.
>
>
> Bugs: MESOS-2293
> https://issues.apache.org/jira/browse/MESOS-2293
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 4dcbc0f3e22f6bdb049da41c950bfc2fbfb89ffa
> src/master/master.cpp 0330f94ad6fe6ac23061e5f45612133747b39a80
>
> Diff: https://reviews.apache.org/r/37263/diff/
>
>
> Testing
> -------
>
> make check
>
> No new tests yet: The plan is to write tests once we update the scheduler library to HTTP.
>
>
> Thanks,
>
> Vinod Kone
>
>