You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/20 18:50:41 UTC

[GitHub] [kafka] ncliang commented on a change in pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

ncliang commented on a change in pull request #8511:
URL: https://github.com/apache/kafka/pull/8511#discussion_r411610839



##########
File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/health/ConnectClusterStateImplTest.java
##########
@@ -87,7 +88,13 @@ public Void answer() {
             }
         });
         EasyMock.replay(herder);
-        assertEquals(expectedConfig, connectClusterState.connectorConfig(connName));
+        Map<String, String> actualConfig = connectClusterState.connectorConfig(connName);
+        assertEquals(expectedConfig, actualConfig);
+        assertNotSame(

Review comment:
       Nice test.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org