You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by imyzf <gi...@git.apache.org> on 2018/06/11 03:49:11 UTC
[GitHub] incubator-weex pull request #1255: * [test] upgrade webpack from 1 to 3
GitHub user imyzf opened a pull request:
https://github.com/apache/incubator-weex/pull/1255
* [test] upgrade webpack from 1 to 3
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
CheckList:
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [x] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imyzf/incubator-weex feature/webpack-upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1255
----
commit df24a33fdc5b0d5002af785f9b183ecd4128c368
Author: Zhenfei You <he...@...>
Date: 2018-06-11T03:43:28Z
* [test] upgrade webpack from 1 to 3
----
---
[GitHub] incubator-weex pull request #1255: * [test] upgrade webpack from 1 to 3
Posted by kuldeepkeshwar <gi...@git.apache.org>.
Github user kuldeepkeshwar commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1255#discussion_r198723000
--- Diff: package.json ---
@@ -134,7 +134,7 @@
"vue": "2.4.3",
"vue-loader": "^12.2.1",
"vue-template-compiler": "2.4.3",
- "webpack": "^1.13.1",
+ "webpack": "^3.12.0",
--- End diff --
I also tried it with Webpack 4, seems like there is an issue with Webpack 4 & vue-loader, will give it another try once it is fixed
---
[GitHub] incubator-weex issue #1255: * [test] upgrade webpack from 1 to 3
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1255
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #1255: * [test] upgrade webpack from 1 to 3
Posted by kuldeepkeshwar <gi...@git.apache.org>.
Github user kuldeepkeshwar commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1255#discussion_r198231562
--- Diff: package.json ---
@@ -134,7 +134,7 @@
"vue": "2.4.3",
"vue-loader": "^12.2.1",
"vue-template-compiler": "2.4.3",
- "webpack": "^1.13.1",
+ "webpack": "^3.12.0",
--- End diff --
can we move to webpack 4 ? will help in build time & bundle optimization
---
[GitHub] incubator-weex pull request #1255: * [test] upgrade webpack from 1 to 3
Posted by Hanks10100 <gi...@git.apache.org>.
Github user Hanks10100 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/1255#discussion_r198371313
--- Diff: package.json ---
@@ -134,7 +134,7 @@
"vue": "2.4.3",
"vue-loader": "^12.2.1",
"vue-template-compiler": "2.4.3",
- "webpack": "^1.13.1",
+ "webpack": "^3.12.0",
--- End diff --
Yeah, using Webpack 4 is better, but I am not sure if there are some compatibility issues.
---