You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/28 23:37:21 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side cache for pod listing
dongjoon-hyun opened a new pull request #33563:
URL: https://github.com/apache/spark/pull/33563
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888814383
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141805/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888728744
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aaruna commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
aaruna commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678759711
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888892804
Here is the result. All tests passed. I also ran TPCDS test on this PR with enabling this new configuration with `true`. I'll merge this. Thank you all!
```
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- Launcher client dependencies
- SPARK-33615: Launcher client archives
- SPARK-33748: Launcher python client respecting PYSPARK_PYTHON
- SPARK-33748: Launcher python client respecting spark.pyspark.python and spark.pyspark.driver.python
- Launcher python client dependencies using a zip file
- Test basic decommissioning
- Test basic decommissioning with shuffle cleanup
- Test decommissioning with dynamic allocation & shuffle cleanups
- Test decommissioning timeouts
- Run SparkR on simple dataframe.R example
Run completed in 17 minutes, 32 seconds.
Total number of tests run: 26
Suites: completed 2, aborted 0
Tests: succeeded 26, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25:01 min
[INFO] Finished at: 2021-07-29T00:57:26-07:00
[INFO] ------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888846946
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888792663
**[Test build #141805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141805/testReport)** for PR 33563 at commit [`b9898f9`](https://github.com/apache/spark/commit/b9898f9a2e5644bbde128c944d1be3c521943b93).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888850997
Thank you so much, @viirya .
The one K8s IT failure is irrelevant because the default value of this PR is `false`, but I'll run manually on my laptop to make it sure.
```
- Test decommissioning with dynamic allocation & shuffle cleanups *** FAILED ***
The code passed to eventually never returned normally. Attempted 1206 times over 20.010682271999997 minutes. (DecommissionSuite.scala:120)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678730879
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -395,6 +395,14 @@ private[spark] object Config extends Logging {
" positive time value.")
.createWithDefaultString("30s")
+ val KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION =
+ ConfigBuilder("spark.kubernetes.executor.enablePollingWithResourceVersion")
+ .doc("If true, `resourceVersion` is set with `0` during invoking pod listing APIs " +
+ "in order to allow API Server-side caching. This should be used carefully.")
+ .version("3.3.0")
+ .booleanConf
+ .createWithDefault(false)
Review comment:
The default is `false` in order to preserve the previous behavior which requests the consistent data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888850997
Thank you so much, @viirya .
The one K8s IT failure is irrelevant and flaky one, but I'll run manually on my laptop to make it sure.
```
- Test decommissioning with dynamic allocation & shuffle cleanups *** FAILED ***
The code passed to eventually never returned normally. Attempted 1206 times over 20.010682271999997 minutes. (DecommissionSuite.scala:120)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888707195
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141794/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888728935
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888792663
**[Test build #141805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141805/testReport)** for PR 33563 at commit [`b9898f9`](https://github.com/apache/spark/commit/b9898f9a2e5644bbde128c944d1be3c521943b93).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888695638
**[Test build #141794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141794/testReport)** for PR 33563 at commit [`05fc4ac`](https://github.com/apache/spark/commit/05fc4ac2429d002b36b22796cf2e78b4f3435d7f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888728935
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678750928
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
BTW, I'm thinking about that as a next step because the same resource versions already happen in the AS-IS status. `pods.list()` just returns the latest one. It doesn't return a new value always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aaruna commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
aaruna commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678749920
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
> Would it make sense to check the snapShot resource verison returned and only replace if it's newer than the previous snapShot?
+1 to doing this so that setting this to `true` will still not affect Spark if a given k8s-api-server is catching up to latest state from etcd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888689472
**[Test build #141794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141794/testReport)** for PR 33563 at commit [`05fc4ac`](https://github.com/apache/spark/commit/05fc4ac2429d002b36b22796cf2e78b4f3435d7f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888710350
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888839855
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678750928
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
~BTW, I'm thinking about that as a next step because the same resource versions already happen in the AS-IS status. `pods.list()` just returns the latest one. It doesn't return a new value always.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888798434
**[Test build #141805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141805/testReport)** for PR 33563 at commit [`b9898f9`](https://github.com/apache/spark/commit/b9898f9a2e5644bbde128c944d1be3c521943b93).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888821901
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888866290
Thank you @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888707195
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141794/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888707275
Also, cc @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #33563:
URL: https://github.com/apache/spark/pull/33563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678754719
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
I'm taking back my words. I'll revise this PR, ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888846946
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888689472
**[Test build #141794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141794/testReport)** for PR 33563 at commit [`05fc4ac`](https://github.com/apache/spark/commit/05fc4ac2429d002b36b22796cf2e78b4f3435d7f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888846920
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46318/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678858691
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -395,6 +395,14 @@ private[spark] object Config extends Logging {
" positive time value.")
.createWithDefaultString("30s")
+ val KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION =
+ ConfigBuilder("spark.kubernetes.executor.enablePollingWithResourceVersion")
+ .doc("If true, `resourceVersion` is set with `0` during invoking pod listing APIs " +
+ "in order to allow API Server-side caching. This should be used carefully.")
Review comment:
Yes, it's still risky because it gets stale data~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678858087
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -395,6 +395,14 @@ private[spark] object Config extends Logging {
" positive time value.")
.createWithDefaultString("30s")
+ val KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION =
+ ConfigBuilder("spark.kubernetes.executor.enablePollingWithResourceVersion")
+ .doc("If true, `resourceVersion` is set with `0` during invoking pod listing APIs " +
+ "in order to allow API Server-side caching. This should be used carefully.")
Review comment:
Now we replace only when we receive a monotonically increased resourceVersion. Is `This should be used carefully` still necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
holdenk commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678745532
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
Would it make sense to check the snapShot resource verison returned and only replace if it's newer than the previous snapShot? Since in HA fail-over we could go back in time which might be confusing to Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888691603
cc @attilapiros and @holdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678748611
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsPollingSnapshotSource.scala
##########
@@ -55,14 +56,17 @@ private[spark] class ExecutorPodsPollingSnapshotSource(
private class PollRunnable(applicationId: String) extends Runnable {
override def run(): Unit = Utils.tryLogNonFatalError {
logDebug(s"Resynchronizing full executor pod state from Kubernetes.")
- snapshotsStore.replaceSnapshot(kubernetesClient
+ val pods = kubernetesClient
.pods()
.withLabel(SPARK_APP_ID_LABEL, applicationId)
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withoutLabel(SPARK_EXECUTOR_INACTIVE_LABEL, "true")
- .list()
- .getItems
- .asScala.toSeq)
+ val list = if (conf.get(KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION)) {
+ pods.list(new ListOptionsBuilder().withResourceVersion("0").build())
+ } else {
+ pods.list()
+ }
+ snapshotsStore.replaceSnapshot(list.getItems.asScala.toSeq)
Review comment:
Thanks. Yes, definitely, you are right. That's the reason why I added this as `false` with a warning in the conf. It depends on the K8s API server implementation and the cluster situations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888814383
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141805/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33563:
URL: https://github.com/apache/spark/pull/33563#issuecomment-888712958
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33563: [SPARK-36334][K8S] Add a new conf to allow K8s API server-side caching for pod listing
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33563:
URL: https://github.com/apache/spark/pull/33563#discussion_r678859264
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
##########
@@ -395,6 +395,14 @@ private[spark] object Config extends Logging {
" positive time value.")
.createWithDefaultString("30s")
+ val KUBERNETES_EXECUTOR_API_POLLING_WITH_RESOURCE_VERSION =
+ ConfigBuilder("spark.kubernetes.executor.enablePollingWithResourceVersion")
+ .doc("If true, `resourceVersion` is set with `0` during invoking pod listing APIs " +
+ "in order to allow API Server-side caching. This should be used carefully.")
Review comment:
Spark driver still may time-out executor pods because they are not visible to the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org