You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by robert3005 <gi...@git.apache.org> on 2017/07/13 11:47:54 UTC
[GitHub] spark pull request #18621: [SPARK-21400][SQL] Don't overwrite output committ...
GitHub user robert3005 opened a pull request:
https://github.com/apache/spark/pull/18621
[SPARK-21400][SQL] Don't overwrite output committers on append
## What changes were proposed in this pull request?
Stop ignoring user defined output committers in append mode
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robert3005/spark rk/dont-overwrite-committers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18621.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18621
----
commit f36ea0f3a794e948afaecde008200e89f39852d2
Author: Robert Kruszewski <ro...@palantir.com>
Date: 2017-07-12T17:48:14Z
Don't overwrite output committers on append
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18621
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18621
**[Test build #79588 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79588/testReport)** for PR 18621 at commit [`f36ea0f`](https://github.com/apache/spark/commit/f36ea0f3a794e948afaecde008200e89f39852d2).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18621
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by robert3005 <gi...@git.apache.org>.
Github user robert3005 commented on the issue:
https://github.com/apache/spark/pull/18621
Fixed in #18689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18621: [SPARK-21400][SQL] Don't overwrite output committ...
Posted by robert3005 <gi...@git.apache.org>.
Github user robert3005 closed the pull request at:
https://github.com/apache/spark/pull/18621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18621
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79588/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18621
**[Test build #79588 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79588/testReport)** for PR 18621 at commit [`f36ea0f`](https://github.com/apache/spark/commit/f36ea0f3a794e948afaecde008200e89f39852d2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` logInfo(s\"Using user defined output committer class $`
* ` logInfo(s\"Using output committer class $`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18621: [SPARK-21400][SQL] Don't overwrite output committers on ...
Posted by ash211 <gi...@git.apache.org>.
Github user ash211 commented on the issue:
https://github.com/apache/spark/pull/18621
jenkins this is ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org