[GitHub] [incubator-superset] nytai commented on a change in pull request #9211: show edit modal on dashboards list view

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #9211: show edit modal on dashboards list view
URL: https://github.com/apache/incubator-superset/pull/9211#discussion_r387350179
 
 

 ##########
 File path: superset/views/dashboard/api.py
 ##########
 @@ -142,19 +142,26 @@ class DashboardRestApi(DashboardMixin, BaseOwnedModelRestApi):
 
     class_permission_name = "DashboardModelView"
     show_columns = [
+        "id",
         "charts",
         "css",
         "dashboard_title",
         "json_metadata",
         "owners.id",
         "owners.username",
+        "changed_by_name",
+        "changed_by_url",
+        "changed_by.username",
+        "changed_on",
         "position_json",
         "published",
+        "url",
         "slug",
         "table_names",
     ]
     order_columns = ["dashboard_title", "changed_on", "published", "changed_by_fk"]
     list_columns = [
+        "json_metadata",
 
 Review comment:
   Is this property consumed in the listview? Seems like we're fetching the full dashboard show payload on edit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org