You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/03/20 02:03:51 UTC
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Hello Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12798
to review the following change.
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
IMPALA-6642 (Part 2): clean up start-impala-cluster.py
We clean up start-impala-cluster.py in general in this patch by using
logging instead of "print" and formatting strings using the format()
function. We make sure to include a timestamp in each log message in
order to make it easier to debug failures in custom cluster tests that
happen when starting the cluster.
Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Reviewed-on: http://gerrit.cloudera.org:8080/10780
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/start-impala-cluster.py
M tests/common/impala_service.py
2 files changed, 147 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/12798/1
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1:
(22 comments)
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@27
PS1, Line 27: from datetime import datetime
flake8: F401 'datetime.datetime' imported but unused
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@35
PS1, Line 35: d
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@52
PS1, Line 52:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@104
PS1, Line 104: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@107
PS1, Line 107: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@110
PS1, Line 110: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@182
PS1, Line 182: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@236
PS1, Line 236: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@237
PS1, Line 237: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@238
PS1, Line 238: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@239
PS1, Line 239: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@302
PS1, Line 302: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@303
PS1, Line 303: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@304
PS1, Line 304: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@305
PS1, Line 305: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@416
PS1, Line 416: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@437
PS1, Line 437: n
flake8: E121 continuation line under-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@460
PS1, Line 460: o
flake8: E129 visually indented line with same indent as next logical line
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@484
PS1, Line 484: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@495
PS1, Line 495: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/bin/start-impala-cluster.py@525
PS1, Line 525: "
flake8: E128 continuation line under-indented for visual indent
http://gerrit.cloudera.org:8080/#/c/12798/1/tests/common/impala_service.py
File tests/common/impala_service.py:
http://gerrit.cloudera.org:8080/#/c/12798/1/tests/common/impala_service.py@39
PS1, Line 39: d
flake8: E128 continuation line under-indented for visual indent
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:04:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
IMPALA-6642 (Part 2): clean up start-impala-cluster.py
We clean up start-impala-cluster.py in general in this patch by using
logging instead of "print" and formatting strings using the format()
function. We make sure to include a timestamp in each log message in
order to make it easier to debug failures in custom cluster tests that
happen when starting the cluster.
Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Reviewed-on: http://gerrit.cloudera.org:8080/10780
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/12798
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/start-impala-cluster.py
M tests/common/impala_service.py
2 files changed, 147 insertions(+), 83 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3931/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 04:38:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 08:24:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 15:32:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2471/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:42:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-6642 (Part 2): clean up start-impala-cluster.py
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12798 )
Change subject: IMPALA-6642 (Part 2): clean up start-impala-cluster.py
......................................................................
Patch Set 1:
This is a clean pick.
--
To view, visit http://gerrit.cloudera.org:8080/12798
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I60169203c61ae6bc0a3ccd3dea355799b603efe5
Gerrit-Change-Number: 12798
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Mar 2019 02:26:03 +0000
Gerrit-HasComments: No