[GitHub] [pulsar] BewareMyPower commented on pull request #19727: [fix][broker] Fix index generator is not rollback after entries are failed added.

["BewareMyPower (via GitHub)" <gi...@apache.org>]

BewareMyPower commented on PR #19727:
URL: https://github.com/apache/pulsar/pull/19727#issuecomment-1465739941

   > We should have discussed about this change on the mailing
   
   It makes sense to me.
   
   I'm also wondering whether it's accepted to add a default method to an interface for release branches. The initial purpose to prevent API changes to release branches is to ensure users can upgrade X.Y.Z to X.Y.(Z+1) without modifying any existing code. For example, if any method signature of `BrokerEntryMetadataInterceptor` is modified, all existing plugins (protocol handlers, connectors, etc.) that use an interceptor could be affected. I'm not sure whether adding a default method could affect the compatibility.
   
   Since @gaozhangmin added the labels to cherry-pick this PR to release branches, could you drive the discussion in the mail list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org