You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Michael Meeks <mi...@suse.com> on 2012/04/19 18:14:32 UTC

OOo / zlib license oddness ...

Hi guys,

	I've been meaning to poke you guys about this; but perhaps your RAT
scan found it already[1]. If you poke in zlib/ there is a patch[2] (to
create a makefile), that looks just fine on the first few reads:

zlib/zlib-1.2.5.patch 
...
+SLOFILES= $(SLO)$/adler32.obj \
....
+          $(SLO)$/unzip.obj   \

	Modules that seem to come from the same (sane) zlib directory, but then
there is this:

+$(MISC)$/%.c : contrib$/minizip$/%.c
+	@echo ------------------------------
+	@echo Making: $@
+    @$(COPY) $< $@

	which copies files out of the contrib/minizip/ directory into there.
Their headers appear uniformly licensed, -but- the .c files that are
copied in have confusing licensing eg. unzip.c

...
  See the accompanying file LICENSE, version 2000-Apr-09 or later
  (the contents of which are also included in zip.h) for terms of use.
  If, for some reason, all these files are missing, the Info-ZIP license
  also may be found at:  ftp://ftp.info-zip.org/pub/infozip/license.html
...

	So - I was wondering: do you guys have the Info-ZIP license in your
notices / documentation etc. ? not sure which category it is ? I believe
it's used by spotlight and some windows integration but not on Linux
etc.

	Hopefully it's in time to get right in your release.

	ATB,

		Michael.

[1] - IMHO, only a compiler/pre-processor can -really- get to the bottom
      of this kind of deep badness, no idea how that rat thing works.
[2] - interestingly it is flagged:
	"Copyright according the GNU Public License"
      seemingly nonsensical; though there are another 5x extant
      instances of that string.
-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Re: OOo / zlib license oddness ...

Posted by Andre Fischer <af...@a-w-f.de>.
Hi Michael,

On 23.04.2012 21:40, Michael Meeks wrote:
> Hi Andre,
>
> On Fri, 2012-04-20 at 10:35 +0800, Andre Fischer wrote:
>> Thanks Michael for your analysis.
>
> 	No problem :-) hope it helps.
>
>> I dont't think that copying the files is a problem.  After all we are
>> already unzipping the zlib tar ball to a location of our choosing.  Why
>> should copying some of the files to yet another location change
>> anything ?
>
> 	Copying these files, obscures the fact that unzip.c and another file (I
> forget which) come from contrib/minizip and not the normal, well
> understood main zlib source, which people are used to having
> well-understood and sane licensing.

No, I don't think so.  Everything after typing
     build <RETURN>
is an intermediate state that only the compiler, linker, and other tools 
are working on.  Otherwise you could argue that any temporary file 
created by the compiler etc. would obscure the situation.

>
>>   They are not part of the source package and the binary packages will
>> contain the resulting zlib library anyway, regardless of the location
>> of any of its source files.  But, of course, I am not a laywer.
>
> 	Of course ! the resulting zlib binary will contained a compiled version
> of zlib/contrib/minizip/unzip.c - as I see it anyhow - not for Linux,
> but for Windows and Mac. And naturally neither of us are lawyers :-)
>
>> Regarding the license issue:
>> I agree that the licensing may appear to be confusing because the
>> LICENSE file referenced in unzip.c is missing.
>
> 	Quite, the question is, what did that file contain ? and/or where is
> it ?
>
>>    But if you look closely
>> at the text, it says that the license text is also included in zip.h,
>> and that file exists and contains the same license text that is also
>> listed in MiniZip64_info.txt (in the same directory.)  That license is
> ...
>> This text is contained in main/LICENSE at around line 2017.  I see no
>> problem with this.
>
> 	It seems highly unclear to me; the contrib code is ( I assume ) dropped
> in from a separate project / location. The unzip.c header reads:

Well, there are many possible origins, none of which seem important to 
me.  I am more interested in the status quo which, as I said before, 
does not look like a problem.

>
> https://github.com/madler/zlib/blob/master/contrib/minizip/unzip.c#L16
>
> [snip]
>        Decryption code comes from crypt.c by Info-ZIP but has been
> ...
>        See the accompanying file LICENSE, version 2000-Apr-09 or later
>        (the contents of which are also included in zip.h) for terms of use.
>        If, for some reason, all these files are missing, the Info-ZIP license
>        also may be found at:  ftp://ftp.info-zip.org/pub/infozip/license.html
> [/snip]
>
> 	There is no LICENSE file in this directory, nor in the minizip
> distribution itself ;-) Interestingly api.c also claims to be api.h, and
> there is plenty of scope for obsolete / un-audited statements there.
> Presumably this is why it lives in contrib/
>
> 	As we agree, this is somewhat confusing;

No.  I said that it may appear confusing.  I also pointed out that the 
comments in zip.h explicitly state several fallbacks in case the LICENSE 
file is missing.

So, no real confusion and no problem there.

> however - given that
> confusion, we have a handy link to the infozip license embedded, and the
> ftp link (to an HTML page!) still resolves, and produces a page
> containing:
>
> 	"This is version 2009-Jan-02 of the Info-ZIP license."
>
> 	which seems similar to the versioning of the (now gone) file referred
> to in the unzip.c file (right?). There are a number of other conditions
> there:
>
> 	ftp://ftp.info-zip.org/pub/infozip/license.html
>
> 	My suspicion is that, perhaps, that code was copied from infozip's
> package, whose download I just hunted down for you here:
>
> 	http://sourceforge.net/projects/infozip/develop
>
> 	Which contains a LICENSE file and a different zip.h reference.
>
> 	Sadly I don't have more time to dig into this for you guys.

No problem, thanks for your work.

> Of course,
> with luck it's not an issue; it's certainly a rather convoluted one, and
> it's only for some rather unclear / small pieces of unzip.c.

I am confident that we don't need luck :-)

And I don't see any unclear items remaining.


Best regards,
Andre

Re: OOo / zlib license oddness ...

Posted by Michael Meeks <mi...@suse.com>.
Hi Andre,

On Fri, 2012-04-20 at 10:35 +0800, Andre Fischer wrote:
> Thanks Michael for your analysis.

	No problem :-) hope it helps.

> I dont't think that copying the files is a problem.  After all we are 
> already unzipping the zlib tar ball to a location of our choosing.  Why 
> should copying some of the files to yet another location change 
> anything ?

	Copying these files, obscures the fact that unzip.c and another file (I
forget which) come from contrib/minizip and not the normal, well
understood main zlib source, which people are used to having
well-understood and sane licensing.

>  They are not part of the source package and the binary packages will
> contain the resulting zlib library anyway, regardless of the location
> of any of its source files.  But, of course, I am not a laywer.

	Of course ! the resulting zlib binary will contained a compiled version
of zlib/contrib/minizip/unzip.c - as I see it anyhow - not for Linux,
but for Windows and Mac. And naturally neither of us are lawyers :-)

> Regarding the license issue:
> I agree that the licensing may appear to be confusing because the 
> LICENSE file referenced in unzip.c is missing.

	Quite, the question is, what did that file contain ? and/or where is
it ?

>   But if you look closely 
> at the text, it says that the license text is also included in zip.h, 
> and that file exists and contains the same license text that is also 
> listed in MiniZip64_info.txt (in the same directory.)  That license is
...
> This text is contained in main/LICENSE at around line 2017.  I see no 
> problem with this.

	It seems highly unclear to me; the contrib code is ( I assume ) dropped
in from a separate project / location. The unzip.c header reads:

https://github.com/madler/zlib/blob/master/contrib/minizip/unzip.c#L16

[snip]
      Decryption code comes from crypt.c by Info-ZIP but has been
...
      See the accompanying file LICENSE, version 2000-Apr-09 or later
      (the contents of which are also included in zip.h) for terms of use.
      If, for some reason, all these files are missing, the Info-ZIP license
      also may be found at:  ftp://ftp.info-zip.org/pub/infozip/license.html
[/snip]

	There is no LICENSE file in this directory, nor in the minizip
distribution itself ;-) Interestingly api.c also claims to be api.h, and
there is plenty of scope for obsolete / un-audited statements there.
Presumably this is why it lives in contrib/

	As we agree, this is somewhat confusing; however - given that
confusion, we have a handy link to the infozip license embedded, and the
ftp link (to an HTML page!) still resolves, and produces a page
containing:

	"This is version 2009-Jan-02 of the Info-ZIP license."

	which seems similar to the versioning of the (now gone) file referred
to in the unzip.c file (right?). There are a number of other conditions
there:

	ftp://ftp.info-zip.org/pub/infozip/license.html

	My suspicion is that, perhaps, that code was copied from infozip's
package, whose download I just hunted down for you here:

	http://sourceforge.net/projects/infozip/develop

	Which contains a LICENSE file and a different zip.h reference.

	Sadly I don't have more time to dig into this for you guys. Of course,
with luck it's not an issue; it's certainly a rather convoluted one, and
it's only for some rather unclear / small pieces of unzip.c.

	All the best,

		Michael.

-- 
michael.meeks@suse.com  <><, Pseudo Engineer, itinerant idiot


Re: OOo / zlib license oddness ...

Posted by Andre Fischer <af...@a-w-f.de>.
Thanks Michael for your analysis.

I dont't think that copying the files is a problem.  After all we are 
already unzipping the zlib tar ball to a location of our choosing.  Why 
should copying some of the files to yet another location change 
anything?  They are not part of the source package and the binary 
packages will contain the resulting zlib library anyway, regardless of 
the location of any of its source files.  But, of course, I am not a laywer.

Regarding the license issue:
I agree that the licensing may appear to be confusing because the 
LICENSE file referenced in unzip.c is missing.  But if you look closely 
at the text, it says that the license text is also included in zip.h, 
and that file exists and contains the same license text that is also 
listed in MiniZip64_info.txt (in the same directory.)  That license is


    Condition of use and distribution are the same than zlib :

   This software is provided 'as-is', without any express or implied
   warranty.  In no event will the authors be held liable for any damages
   arising from the use of this software.

   Permission is granted to anyone to use this software for any purpose,
   including commercial applications, and to alter it and redistribute it
   freely, subject to the following restrictions:

   1. The origin of this software must not be misrepresented; you must not
      claim that you wrote the original software. If you use this software
      in a product, an acknowledgment in the product documentation would be
      appreciated but is not required.
   2. Altered source versions must source/current/git/main/zlib/be 
plainly marked as such, and must not be
      misrepresented as being the original software.
   3. This notice may not be removed or altered from any source 
distribution.



This text is contained in main/LICENSE at around line 2017.  I see no 
problem with this.

More comments inline.

On 20.04.2012 00:14, Michael Meeks wrote:
> Hi guys,
>
> 	I've been meaning to poke you guys about this; but perhaps your RAT
> scan found it already[1]. If you poke in zlib/ there is a patch[2] (to
> create a makefile), that looks just fine on the first few reads:
>
> zlib/zlib-1.2.5.patch
> ...
> +SLOFILES= $(SLO)$/adler32.obj \
> ....
> +          $(SLO)$/unzip.obj   \
>
> 	Modules that seem to come from the same (sane) zlib directory, but then
> there is this:
>
> +$(MISC)$/%.c : contrib$/minizip$/%.c
> +	@echo ------------------------------
> +	@echo Making: $@
> +    @$(COPY) $<  $@
>
> 	which copies files out of the contrib/minizip/ directory into there.
> Their headers appear uniformly licensed, -but- the .c files that are
> copied in have confusing licensing eg. unzip.c
>
> ...
>    See the accompanying file LICENSE, version 2000-Apr-09 or later
>    (the contents of which are also included in zip.h) for terms of use.
>    If, for some reason, all these files are missing, the Info-ZIP license
>    also may be found at:  ftp://ftp.info-zip.org/pub/infozip/license.html
> ...
>
> 	So - I was wondering: do you guys have the Info-ZIP license in your
> notices / documentation etc. ? not sure which category it is ? I believe
> it's used by spotlight and some windows integration but not on Linux
> etc.
>
> 	Hopefully it's in time to get right in your release.
>

Absolutely.  But it is good that you finished your analysis of the 
source code before the RC and not after so that people don't get the 
wrong impression about your intentions.

Best regards,

Andre


> 	ATB,
>
> 		Michael.
>
> [1] - IMHO, only a compiler/pre-processor can -really- get to the bottom
>        of this kind of deep badness, no idea how that rat thing works.
> [2] - interestingly it is flagged:
> 	"Copyright according the GNU Public License"
>        seemingly nonsensical; though there are another 5x extant
>        instances of that string.