[GitHub] [superset] michael-s-molina commented on a change in pull request #19415: chore: Remove Control.less in Explore

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #19415:
URL: https://github.com/apache/superset/pull/19415#discussion_r840729450



##########
File path: superset-frontend/src/explore/components/Control.tsx
##########
@@ -76,7 +78,7 @@ export default function Control(props: ControlProps) {
   }
 
   return (
-    <div
+    <StyledControl
       className="Control"

Review comment:
       Can we change the Cypress tests to query by role or an id? Leaving the class name misleads the developers when maintaining the style because they need to look for the class definition to avoid conflicts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org