You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/21 01:59:45 UTC

[GitHub] [spark] younggyuchun opened a new pull request #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

younggyuchun opened a new pull request #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   This PR aims to replace functions that convert dates to/from "timestamp" in millisecond precision by functions that 
   1. Replace millisToDays by microsToDays in DateTimeUtils.
   2. Replace daysToMillis by daysToMicros in DateTimeUtils.
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   Spark should reduce overhead costs to convert dates to a timestamp in milliseconds. TimestamType values in the Catalyst are stored as microseconds. Recently we switched to Java 8 time API so we do not need to convert to milliseconds. 
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463439
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23492/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473025
 
 
   **[Test build #118744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118744/testReport)** for PR 27661 at commit [`130baec`](https://github.com/apache/spark/commit/130baec9c9f89169ca6d83594dcfe334c7c2c33e).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589478517
 
 
   **[Test build #118744 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118744/testReport)** for PR 27661 at commit [`130baec`](https://github.com/apache/spark/commit/130baec9c9f89169ca6d83594dcfe334c7c2c33e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463432
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473338
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589478559
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] younggyuchun commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
younggyuchun commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465195
 
 
   cc @MaxGekk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465492
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589478568
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118744/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589478568
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118744/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473345
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23495/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463439
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23492/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463432
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465494
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118741/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473345
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23495/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463124
 
 
   **[Test build #118741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118741/testReport)** for PR 27661 at commit [`0fd79de`](https://github.com/apache/spark/commit/0fd79dea15c6e0b300b329613a112906da7c294c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589503673
 
 
   This PR is a duplicate work of my PR https://github.com/apache/spark/pull/27618 opened 3 days ago. I would like to kindly ask you to close it. /cc @cloud-fan @dongjoon-hyun @srowen @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589463124
 
 
   **[Test build #118741 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118741/testReport)** for PR 27661 at commit [`0fd79de`](https://github.com/apache/spark/commit/0fd79dea15c6e0b300b329613a112906da7c294c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473025
 
 
   **[Test build #118744 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118744/testReport)** for PR 27661 at commit [`130baec`](https://github.com/apache/spark/commit/130baec9c9f89169ca6d83594dcfe334c7c2c33e).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589523563
 
 
   Let's close and review #27618 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589473338
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589478559
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465494
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118741/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] younggyuchun edited a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
younggyuchun edited a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465195
 
 
   I can't add MaxGekk as a reviewer.  cc @MaxGekk 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465477
 
 
   **[Test build #118741 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118741/testReport)** for PR 27661 at commit [`0fd79de`](https://github.com/apache/spark/commit/0fd79dea15c6e0b300b329613a112906da7c294c).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27661: [SPARK-30869][SQL] Convert dates to/from timestamps in microseconds precision
URL: https://github.com/apache/spark/pull/27661#issuecomment-589465492
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org