You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/11/11 03:53:30 UTC
Review Request 40170: AMBARI-13828. Express Upgrade: Misc fixes for
NameNode in Kerberized cluster, Storm PreCheck, Knox message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40170/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-13828
https://issues.apache.org/jira/browse/AMBARI-13828
Repository: ambari
Description
-------
Four fixes in one Jira.
1. Knox: message to backup data dir and restore them is wrong for 2.2 and 2.3 upgrade packs.
2. Storm: In HDP 2.1, when stopping just STORM_REST_API, still get an error when trying to delete it without stopping entire Service.
3. NameNode: remove the "namenode_desired_role" param since no longer used.
4. NameNode fails to be restarted in kerberized cluster.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 9cee6dd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 530832d
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 807c958
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 91831f7
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml fe698fc
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3f5a56c
Diff: https://reviews.apache.org/r/40170/diff/
Testing
-------
Tested all four fixes,
Python unit tests passed,
----------------------------------------------------------------------
Total run:827
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 40170: AMBARI-13828. Express Upgrade: Misc fixes
for NameNode in Kerberized cluster, Storm PreCheck, Knox message
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Nov. 11, 2015, 6:20 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java, line 82
> > <https://reviews.apache.org/r/40170/diff/1/?file=1122847#file1122847line82>
> >
> > Agree we have to do this right now, but we should change this behaviour. Having to stop the entire service to delete the REST API component is not ideal.
This is how I got it to work in the safest way possible.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40170/#review106111
-----------------------------------------------------------
On Nov. 11, 2015, 2:53 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40170/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:53 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13828
> https://issues.apache.org/jira/browse/AMBARI-13828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Four fixes in one Jira.
>
> 1. Knox: message to backup data dir and restore them is wrong for 2.2 and 2.3 upgrade packs.
> 2. Storm: In HDP 2.1, when stopping just STORM_REST_API, still get an error when trying to delete it without stopping entire Service.
> 3. NameNode: remove the "namenode_desired_role" param since no longer used.
> 4. NameNode fails to be restarted in kerberized cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 9cee6dd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 530832d
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 807c958
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 91831f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml fe698fc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3f5a56c
>
> Diff: https://reviews.apache.org/r/40170/diff/
>
>
> Testing
> -------
>
> Tested all four fixes,
>
> Python unit tests passed,
> ----------------------------------------------------------------------
> Total run:827
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40170: AMBARI-13828. Express Upgrade: Misc fixes
for NameNode in Kerberized cluster, Storm PreCheck, Knox message
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40170/#review106111
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java (line 82)
<https://reviews.apache.org/r/40170/#comment164805>
Agree we have to do this right now, but we should change this behaviour. Having to stop the entire service to delete the REST API component is not ideal.
- Jayush Luniya
On Nov. 11, 2015, 2:53 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40170/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:53 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13828
> https://issues.apache.org/jira/browse/AMBARI-13828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Four fixes in one Jira.
>
> 1. Knox: message to backup data dir and restore them is wrong for 2.2 and 2.3 upgrade packs.
> 2. Storm: In HDP 2.1, when stopping just STORM_REST_API, still get an error when trying to delete it without stopping entire Service.
> 3. NameNode: remove the "namenode_desired_role" param since no longer used.
> 4. NameNode fails to be restarted in kerberized cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 9cee6dd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 530832d
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 807c958
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 91831f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml fe698fc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3f5a56c
>
> Diff: https://reviews.apache.org/r/40170/diff/
>
>
> Testing
> -------
>
> Tested all four fixes,
>
> Python unit tests passed,
> ----------------------------------------------------------------------
> Total run:827
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40170: AMBARI-13828. Express Upgrade: Misc fixes
for NameNode in Kerberized cluster, Storm PreCheck, Knox message
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40170/#review106010
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
<https://reviews.apache.org/r/40170/#comment164709>
No longer used.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py (line 160)
<https://reviews.apache.org/r/40170/#comment164710>
This was failing since it didn't have "params."
- Alejandro Fernandez
On Nov. 11, 2015, 2:53 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40170/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:53 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13828
> https://issues.apache.org/jira/browse/AMBARI-13828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Four fixes in one Jira.
>
> 1. Knox: message to backup data dir and restore them is wrong for 2.2 and 2.3 upgrade packs.
> 2. Storm: In HDP 2.1, when stopping just STORM_REST_API, still get an error when trying to delete it without stopping entire Service.
> 3. NameNode: remove the "namenode_desired_role" param since no longer used.
> 4. NameNode fails to be restarted in kerberized cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 9cee6dd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 530832d
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 807c958
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 91831f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml fe698fc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3f5a56c
>
> Diff: https://reviews.apache.org/r/40170/diff/
>
>
> Testing
> -------
>
> Tested all four fixes,
>
> Python unit tests passed,
> ----------------------------------------------------------------------
> Total run:827
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40170: AMBARI-13828. Express Upgrade: Misc fixes
for NameNode in Kerberized cluster, Storm PreCheck, Knox message
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40170/#review106032
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 11, 2015, 4:53 a.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40170/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 4:53 a.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jayush Luniya, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13828
> https://issues.apache.org/jira/browse/AMBARI-13828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Four fixes in one Jira.
>
> 1. Knox: message to backup data dir and restore them is wrong for 2.2 and 2.3 upgrade packs.
> 2. Storm: In HDP 2.1, when stopping just STORM_REST_API, still get an error when trying to delete it without stopping entire Service.
> 3. NameNode: remove the "namenode_desired_role" param since no longer used.
> 4. NameNode fails to be restarted in kerberized cluster.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 9cee6dd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 530832d
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 807c958
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml 91831f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml fe698fc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 3f5a56c
>
> Diff: https://reviews.apache.org/r/40170/diff/
>
>
> Testing
> -------
>
> Tested all four fixes,
>
> Python unit tests passed,
> ----------------------------------------------------------------------
> Total run:827
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>