[jira] [Commented] (OAK-5835) JournalReader should include timestamp information (if available)

["Michael Dürig (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885856#comment-15885856 ] 

Michael Dürig commented on OAK-5835:
------------------------------------

Looks good overall. Just a bit of nitpicking:
* {{JournalEntry}}: I would declare {{revision}} and all its dependencies as {{@NonNull}}. This should simplify downstream code as well as hash end equality implementations. 
* While we are at it we could also simplify and improve {{JournalReader.computeNext()}}: the extra {{IndexOf(' ')}} check seems not necessary. We could instead rely on the result of the splitter in the while loop. 
* Instead of silently skipping a line that does not contain a revision we should probably log a warning. Same for lines where the timestamp entry does not parse. 
* From the sideline: {{RevisionHistory.getHistory()}} does not close the {{JournalReader}} instance.

> JournalReader should include timestamp information (if available)
> -----------------------------------------------------------------
>
>                 Key: OAK-5835
>                 URL: https://issues.apache.org/jira/browse/OAK-5835
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-5835.patch
>
>
> Currently the {{journal.log}} has entries like below:
> {code}
> 1d889da9-b41c-4889-a0cd-a9aa9dcc1737:259992 root 1457408708772
> {code}
> At the moment {{JournalReader}} parses only the information regarding head state (first column), without returning anything about the time at which that revision was written (third column). This info needs to be included as well (only if available), without enforcing any check on the format described above.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)