[jira] [Commented] (LIBCLOUD-953) Add possibility to define username to Upcloud driver

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196112#comment-16196112 ] 

ASF GitHub Bot commented on LIBCLOUD-953:
-----------------------------------------

GitHub user mlackman opened a pull request:

    https://github.com/apache/libcloud/pull/1125

    [LIBCLOUD-953] Add possibility to define username to Upcloud driver

    ex_username parameter added and refactored test to use common parameters
    
    ## ex_username added to create_node
    
    ### Description
    
    Added ex_username to create_node, so that clients can define username, which is created to host.
    The default username is 'root', which is UpCloud's REST API's default username.
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    -  [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/UpCloudLtd/libcloud LIBCLOUD-953_Add_possibility_to_define_username_to_UpCloud_driver

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
    
----
commit 3417ba9b97cd8a58b80e2c24d252bb8678ce247d
Author: Mika Lackman <mi...@upcloud.com>
Date:   2017-10-07T16:31:53Z

    ex_username parameter added and
    refactored test to use common parameters

----


> Add possibility to define username to Upcloud driver
> ----------------------------------------------------
>
>                 Key: LIBCLOUD-953
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-953
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Mika Lackman
>
> Add ex_username to upcloud node driver to allow client to define the user, which will be created to node.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)