You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2019/09/09 19:54:21 UTC

Flaky test X509UtilTest.testClientRenegotiationFails ?

Hi,
I am testing on branch-3.5.6, I see that this test is very flaky on JDK8
(1.8.0_222 on Linux)

X509UtilTest.testClientRenegotiationFails

I see the test passing consistently on JDK12

does anyone ever see this kind of problem ?

I am investigating, but any help will be very appreciated

Enrico

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Enrico Olivelli <eo...@gmail.com>.
I found the issue, the test falls into a race condition, so on a slow
machine the test become more "flaky".
It is interesting that on modern JDKs even on a slow machine the test never
fails.

here is the fix
https://github.com/apache/zookeeper/pull/1088/files

This is for branch-3.5, I will cherry pick to branch-3.5.6

I have also sent another patch for branch-3.5 to be cherry picked to
branch-3.5.6 about Apache RAT check
https://issues.apache.org/jira/browse/ZOOKEEPER-3440
https://github.com/apache/zookeeper/pull/1086
it is only a backport from master

Please take a look

After those commits I am close to sending the VOTE email for 3.5.6

Cheers
Enrico


Il giorno mer 11 set 2019 alle ore 17:56 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:

> I have re run again the tests with jdk8 + MacOs without problem.
>
> The Linux box in which I have problems has only 2 cores, maybe such
> problem is only with machines with a small number of cores
>
> Enrico
>
> Il giorno mer 11 set 2019 alle ore 15:27 Enrico Olivelli <
> eolivelli@gmail.com> ha scritto:
>
>> I am on Fedora+adoptopenjdk.
>> I will be back with debug I info
>>
>> On my Mac the VM is crashing!
>>
>> Enrico
>>
>> Il mer 11 set 2019, 14:14 Andor Molnar <an...@apache.org> ha scritto:
>>
>>> Run it a few times on Mac, but still not failing.
>>>
>>> openjdk version "1.8.0_222"
>>> OpenJDK Runtime Environment (build 1.8.0_222-b10)
>>> Eclipse OpenJ9 VM (build openj9-0.15.1, JRE 1.8.0 Mac OS X amd64-64-Bit
>>> Compressed References 20190717_298 (JIT enabled, AOT enabled)
>>> OpenJ9   - 0f66c6431
>>> OMR      - ec782f26
>>> JCL      - f147086df1 based on jdk8u222-b10)
>>>
>>> Andor
>>>
>>>
>>>
>>> > On 2019. Sep 10., at 20:38, Enrico Olivelli <eo...@gmail.com>
>>> wrote:
>>> >
>>> > I am using AdoptOpenJDK I see you are using Zulu, can you try with my
>>> > version please?
>>> >
>>> > Enrico
>>> >
>>> > Il mar 10 set 2019, 19:38 Andor Molnar <an...@apache.org> ha scritto:
>>> >
>>> >> This is running fine for me on both Java 8 and 11 on Debian 10.
>>> >> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu
>>> 8.40.0.25-
>>> >> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
>>> >> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
>>> >> I run X509UtilTest multiple times, but never failed.
>>> >> Andor
>>> >>
>>> >> -----Original Message-----From: Enrico Olivelli <eolivelli@gmail.com
>>> >Re
>>> >> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
>>> >> dev@zookeeper.apache.org>Subject: Re: Flaky test
>>> >> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
>>> >> 18:40:29 +0200
>>> >> Sorry I missed to attach the error message:INFO] Running
>>> >> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
>>> >> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
>>> >> - in
>>> >>
>>> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
>>> >> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
>>> >> s  <<< ERROR!java.lang.Exception: Unexpected
>>> >> exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
>>> >> UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
>>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
>>> >> UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
>>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
>>> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
>>> >> UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
>>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
>>> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>>> >>
>>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>>> >>
>>> >> It is related to some combinations of the parametrized testI will
>>> debug
>>> >> as soon as I have cycles
>>> >> Enrico
>>> >> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <
>>> andor@apache.org
>>> >>> hascritto:
>>> >>> What is the error message exactly?
>>> >>> I don’t see this test failing on any of 3.5 builds here:
>>> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>> >>>
>>> >>> Neither in the flaky test report:
>>> >>>
>>> >>
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
>>> >>>
>>> >>> Andor
>>> >>>
>>> >>>
>>> >>>> On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
>>> >>>> wrote:
>>> >>>> Hi,I am testing on branch-3.5.6, I see that this test is very flaky
>>> >>>> on JDK8(1.8.0_222 on Linux)
>>> >>>> X509UtilTest.testClientRenegotiationFails
>>> >>>> I see the test passing consistently on JDK12
>>> >>>> does anyone ever see this kind of problem ?
>>> >>>> I am investigating, but any help will be very appreciated
>>> >>>> Enrico
>>> >>
>>>
>>>

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Enrico Olivelli <eo...@gmail.com>.
I have re run again the tests with jdk8 + MacOs without problem.

The Linux box in which I have problems has only 2 cores, maybe such problem
is only with machines with a small number of cores

Enrico

Il giorno mer 11 set 2019 alle ore 15:27 Enrico Olivelli <
eolivelli@gmail.com> ha scritto:

> I am on Fedora+adoptopenjdk.
> I will be back with debug I info
>
> On my Mac the VM is crashing!
>
> Enrico
>
> Il mer 11 set 2019, 14:14 Andor Molnar <an...@apache.org> ha scritto:
>
>> Run it a few times on Mac, but still not failing.
>>
>> openjdk version "1.8.0_222"
>> OpenJDK Runtime Environment (build 1.8.0_222-b10)
>> Eclipse OpenJ9 VM (build openj9-0.15.1, JRE 1.8.0 Mac OS X amd64-64-Bit
>> Compressed References 20190717_298 (JIT enabled, AOT enabled)
>> OpenJ9   - 0f66c6431
>> OMR      - ec782f26
>> JCL      - f147086df1 based on jdk8u222-b10)
>>
>> Andor
>>
>>
>>
>> > On 2019. Sep 10., at 20:38, Enrico Olivelli <eo...@gmail.com>
>> wrote:
>> >
>> > I am using AdoptOpenJDK I see you are using Zulu, can you try with my
>> > version please?
>> >
>> > Enrico
>> >
>> > Il mar 10 set 2019, 19:38 Andor Molnar <an...@apache.org> ha scritto:
>> >
>> >> This is running fine for me on both Java 8 and 11 on Debian 10.
>> >> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu 8.40.0.25-
>> >> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
>> >> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
>> >> I run X509UtilTest multiple times, but never failed.
>> >> Andor
>> >>
>> >> -----Original Message-----From: Enrico Olivelli <eolivelli@gmail.com
>> >Re
>> >> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
>> >> dev@zookeeper.apache.org>Subject: Re: Flaky test
>> >> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
>> >> 18:40:29 +0200
>> >> Sorry I missed to attach the error message:INFO] Running
>> >> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
>> >> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
>> >> - in
>> >> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
>> >> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
>> >> s  <<< ERROR!java.lang.Exception: Unexpected
>> >> exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
>> >> UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
>> >> UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
>> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
>> >> UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
>> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> >>
>> >> It is related to some combinations of the parametrized testI will debug
>> >> as soon as I have cycles
>> >> Enrico
>> >> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <
>> andor@apache.org
>> >>> hascritto:
>> >>> What is the error message exactly?
>> >>> I don’t see this test failing on any of 3.5 builds here:
>> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>> >>>
>> >>> Neither in the flaky test report:
>> >>>
>> >>
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
>> >>>
>> >>> Andor
>> >>>
>> >>>
>> >>>> On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
>> >>>> wrote:
>> >>>> Hi,I am testing on branch-3.5.6, I see that this test is very flaky
>> >>>> on JDK8(1.8.0_222 on Linux)
>> >>>> X509UtilTest.testClientRenegotiationFails
>> >>>> I see the test passing consistently on JDK12
>> >>>> does anyone ever see this kind of problem ?
>> >>>> I am investigating, but any help will be very appreciated
>> >>>> Enrico
>> >>
>>
>>

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Enrico Olivelli <eo...@gmail.com>.
I am on Fedora+adoptopenjdk.
I will be back with debug I info

On my Mac the VM is crashing!

Enrico

Il mer 11 set 2019, 14:14 Andor Molnar <an...@apache.org> ha scritto:

> Run it a few times on Mac, but still not failing.
>
> openjdk version "1.8.0_222"
> OpenJDK Runtime Environment (build 1.8.0_222-b10)
> Eclipse OpenJ9 VM (build openj9-0.15.1, JRE 1.8.0 Mac OS X amd64-64-Bit
> Compressed References 20190717_298 (JIT enabled, AOT enabled)
> OpenJ9   - 0f66c6431
> OMR      - ec782f26
> JCL      - f147086df1 based on jdk8u222-b10)
>
> Andor
>
>
>
> > On 2019. Sep 10., at 20:38, Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > I am using AdoptOpenJDK I see you are using Zulu, can you try with my
> > version please?
> >
> > Enrico
> >
> > Il mar 10 set 2019, 19:38 Andor Molnar <an...@apache.org> ha scritto:
> >
> >> This is running fine for me on both Java 8 and 11 on Debian 10.
> >> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu 8.40.0.25-
> >> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
> >> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
> >> I run X509UtilTest multiple times, but never failed.
> >> Andor
> >>
> >> -----Original Message-----From: Enrico Olivelli <eo...@gmail.com>Re
> >> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
> >> dev@zookeeper.apache.org>Subject: Re: Flaky test
> >> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
> >> 18:40:29 +0200
> >> Sorry I missed to attach the error message:INFO] Running
> >> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
> >> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
> >> - in
> >> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
> >> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
> >> s  <<< ERROR!java.lang.Exception: Unexpected
> >> exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
> >> UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
> >> UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
> >> UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
> >> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
> >> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> >> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> >> est.testClientRenegotiationFails(X509UtilTest.java:579)
> >>
> >> It is related to some combinations of the parametrized testI will debug
> >> as soon as I have cycles
> >> Enrico
> >> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <andor@apache.org
> >>> hascritto:
> >>> What is the error message exactly?
> >>> I don’t see this test failing on any of 3.5 builds here:
> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
> >>>
> >>> Neither in the flaky test report:
> >>>
> >>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
> >>>
> >>> Andor
> >>>
> >>>
> >>>> On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
> >>>> wrote:
> >>>> Hi,I am testing on branch-3.5.6, I see that this test is very flaky
> >>>> on JDK8(1.8.0_222 on Linux)
> >>>> X509UtilTest.testClientRenegotiationFails
> >>>> I see the test passing consistently on JDK12
> >>>> does anyone ever see this kind of problem ?
> >>>> I am investigating, but any help will be very appreciated
> >>>> Enrico
> >>
>
>

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Andor Molnar <an...@apache.org>.
Run it a few times on Mac, but still not failing.

openjdk version "1.8.0_222"
OpenJDK Runtime Environment (build 1.8.0_222-b10)
Eclipse OpenJ9 VM (build openj9-0.15.1, JRE 1.8.0 Mac OS X amd64-64-Bit Compressed References 20190717_298 (JIT enabled, AOT enabled)
OpenJ9   - 0f66c6431
OMR      - ec782f26
JCL      - f147086df1 based on jdk8u222-b10)

Andor



> On 2019. Sep 10., at 20:38, Enrico Olivelli <eo...@gmail.com> wrote:
> 
> I am using AdoptOpenJDK I see you are using Zulu, can you try with my
> version please?
> 
> Enrico
> 
> Il mar 10 set 2019, 19:38 Andor Molnar <an...@apache.org> ha scritto:
> 
>> This is running fine for me on both Java 8 and 11 on Debian 10.
>> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu 8.40.0.25-
>> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
>> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
>> I run X509UtilTest multiple times, but never failed.
>> Andor
>> 
>> -----Original Message-----From: Enrico Olivelli <eo...@gmail.com>Re
>> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
>> dev@zookeeper.apache.org>Subject: Re: Flaky test
>> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
>> 18:40:29 +0200
>> Sorry I missed to attach the error message:INFO] Running
>> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
>> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
>> - in
>> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
>> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
>> s  <<< ERROR!java.lang.Exception: Unexpected
>> exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
>> UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
>> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
>> UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
>> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
>> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
>> UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
>> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
>> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
>> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
>> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
>> est.testClientRenegotiationFails(X509UtilTest.java:579)
>> 
>> It is related to some combinations of the parametrized testI will debug
>> as soon as I have cycles
>> Enrico
>> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <andor@apache.org
>>> hascritto:
>>> What is the error message exactly?
>>> I don’t see this test failing on any of 3.5 builds here:
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>>> 
>>> Neither in the flaky test report:
>>> 
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
>>> 
>>> Andor
>>> 
>>> 
>>>> On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
>>>> wrote:
>>>> Hi,I am testing on branch-3.5.6, I see that this test is very flaky
>>>> on JDK8(1.8.0_222 on Linux)
>>>> X509UtilTest.testClientRenegotiationFails
>>>> I see the test passing consistently on JDK12
>>>> does anyone ever see this kind of problem ?
>>>> I am investigating, but any help will be very appreciated
>>>> Enrico
>> 


Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Enrico Olivelli <eo...@gmail.com>.
I am using AdoptOpenJDK I see you are using Zulu, can you try with my
version please?

Enrico

Il mar 10 set 2019, 19:38 Andor Molnar <an...@apache.org> ha scritto:

> This is running fine for me on both Java 8 and 11 on Debian 10.
> openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu 8.40.0.25-
> CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
> 8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
> I run X509UtilTest multiple times, but never failed.
> Andor
>
> -----Original Message-----From: Enrico Olivelli <eo...@gmail.com>Re
> ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
> dev@zookeeper.apache.org>Subject: Re: Flaky test
> X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
> 18:40:29 +0200
> Sorry I missed to attach the error message:INFO] Running
> org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
> Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
> - in
> org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
> ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
> s  <<< ERROR!java.lang.Exception: Unexpected
> exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
> [ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
> UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
> [ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
> UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
> [ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
> [ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
> UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
> [ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
> UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
> Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
> butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
> est.testClientRenegotiationFails(X509UtilTest.java:579)
>
> It is related to some combinations of the parametrized testI will debug
> as soon as I have cycles
> Enrico
> Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <andor@apache.org
> > hascritto:
> > What is the error message exactly?
> > I don’t see this test failing on any of 3.5 builds here:
> > https://builds.apache.org/view/S-Z/view/ZooKeeper/
> >
> > Neither in the flaky test report:
> >
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
> >
> > Andor
> >
> >
> > > On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > > Hi,I am testing on branch-3.5.6, I see that this test is very flaky
> > > on JDK8(1.8.0_222 on Linux)
> > > X509UtilTest.testClientRenegotiationFails
> > > I see the test passing consistently on JDK12
> > > does anyone ever see this kind of problem ?
> > > I am investigating, but any help will be very appreciated
> > > Enrico
>

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Andor Molnar <an...@apache.org>.
This is running fine for me on both Java 8 and 11 on Debian 10.
openjdk version "1.8.0_222"OpenJDK Runtime Environment (Zulu 8.40.0.25-
CA-linux64) (build 1.8.0_222-b10)OpenJDK 64-Bit Server VM (Zulu
8.40.0.25-CA-linux64) (build 25.222-b10, mixed mode)
I run X509UtilTest multiple times, but never failed.
Andor

-----Original Message-----From: Enrico Olivelli <eo...@gmail.com>Re
ply-To: dev@zookeeper.apache.orgTo: DevZooKeeper <
dev@zookeeper.apache.org>Subject: Re: Flaky test
X509UtilTest.testClientRenegotiationFails ?Date: Tue, 10 Sep 2019
18:40:29 +0200
Sorry I missed to attach the error message:INFO] Running
org.apache.zookeeper.common.X509UtilTest[ERROR] Tests run: 336,
Failures: 0, Errors: 6, Skipped: 0, Time elapsed:12.394 s <<< FAILURE!
- in
org.apache.zookeeper.common.X509UtilTest[ERROR]testClientRenegotiationF
ails[0](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.437
s  <<< ERROR!java.lang.Exception: Unexpected
exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)
[ERROR]testClientRenegotiationFails[1](org.apache.zookeeper.common.X509
UtilTest) Time elapsed: 0.065 s  <<< ERROR!java.lang.Exception:
Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)
[ERROR]testClientRenegotiationFails[2](org.apache.zookeeper.common.X509
UtilTest) Time elapsed: 0.071 s  <<< ERROR!java.lang.Exception:
Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)
[ERROR]testClientRenegotiationFails[4](org.apache.zookeeper.common.X509
UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)
[ERROR]testClientRenegotiationFails[5](org.apache.zookeeper.common.X509
UtilTest) Time elapsed: 0.058 s  <<< ERROR!java.lang.Exception:
Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)
[ERROR]testClientRenegotiationFails[7](org.apache.zookeeper.common.X509
UtilTest) Time elapsed: 0.052 s  <<< ERROR!java.lang.Exception:
Unexpected exception,expected<javax.net.ssl.SSLHandshakeException>
butwas<java.lang.AssertionError>atorg.apache.zookeeper.common.X509UtilT
est.testClientRenegotiationFails(X509UtilTest.java:579)

It is related to some combinations of the parametrized testI will debug
as soon as I have cycles
Enrico
Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <andor@apache.org
> hascritto:
> What is the error message exactly?
> I don’t see this test failing on any of 3.5 builds here:
> https://builds.apache.org/view/S-Z/view/ZooKeeper/
> 
> Neither in the flaky test report:
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
> 
> Andor
> 
> 
> > On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > Hi,I am testing on branch-3.5.6, I see that this test is very flaky
> > on JDK8(1.8.0_222 on Linux)
> > X509UtilTest.testClientRenegotiationFails
> > I see the test passing consistently on JDK12
> > does anyone ever see this kind of problem ?
> > I am investigating, but any help will be very appreciated
> > Enrico

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Enrico Olivelli <eo...@gmail.com>.
Sorry I missed to attach the error message:
INFO] Running org.apache.zookeeper.common.X509UtilTest
[ERROR] Tests run: 336, Failures: 0, Errors: 6, Skipped: 0, Time elapsed:
12.394 s <<< FAILURE! - in org.apache.zookeeper.common.X509UtilTest
[ERROR]
testClientRenegotiationFails[0](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.437 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)

[ERROR]
testClientRenegotiationFails[1](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.065 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)

[ERROR]
testClientRenegotiationFails[2](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.071 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)

[ERROR]
testClientRenegotiationFails[4](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.052 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)

[ERROR]
testClientRenegotiationFails[5](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.058 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)

[ERROR]
testClientRenegotiationFails[7](org.apache.zookeeper.common.X509UtilTest)
 Time elapsed: 0.052 s  <<< ERROR!
java.lang.Exception: Unexpected exception,
expected<javax.net.ssl.SSLHandshakeException> but
was<java.lang.AssertionError>
at
org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:579)


It is related to some combinations of the parametrized test
I will debug as soon as I have cycles

Enrico

Il giorno mar 10 set 2019 alle ore 17:32 Andor Molnar <an...@apache.org> ha
scritto:

> What is the error message exactly?
>
> I don’t see this test failing on any of 3.5 builds here:
> https://builds.apache.org/view/S-Z/view/ZooKeeper/
>
> Neither in the flaky test report:
>
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html
>
> Andor
>
>
>
> > On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > Hi,
> > I am testing on branch-3.5.6, I see that this test is very flaky on JDK8
> > (1.8.0_222 on Linux)
> >
> > X509UtilTest.testClientRenegotiationFails
> >
> > I see the test passing consistently on JDK12
> >
> > does anyone ever see this kind of problem ?
> >
> > I am investigating, but any help will be very appreciated
> >
> > Enrico
>
>

Re: Flaky test X509UtilTest.testClientRenegotiationFails ?

Posted by Andor Molnar <an...@apache.org>.
What is the error message exactly?

I don’t see this test failing on any of 3.5 builds here:
https://builds.apache.org/view/S-Z/view/ZooKeeper/

Neither in the flaky test report:
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-Find-Flaky-Tests/lastSuccessfulBuild/artifact/report.html

Andor



> On 2019. Sep 9., at 21:54, Enrico Olivelli <eo...@gmail.com> wrote:
> 
> Hi,
> I am testing on branch-3.5.6, I see that this test is very flaky on JDK8
> (1.8.0_222 on Linux)
> 
> X509UtilTest.testClientRenegotiationFails
> 
> I see the test passing consistently on JDK12
> 
> does anyone ever see this kind of problem ?
> 
> I am investigating, but any help will be very appreciated
> 
> Enrico