You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/20 03:25:38 UTC
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1996: SOLR-14907: Adding V2 API for ConfigSet Upload.
dsmiley commented on a change in pull request #1996:
URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r508186617
##########
File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java
##########
@@ -133,6 +134,62 @@ public void create(PayloadObj<CreateConfigInfo> obj) throws Exception {
}
+ @EndPoint(method = POST,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSet(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = PUT,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSetWithOverwrite(SolrQueryRequest req, SolrQueryResponse rsp) throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"),
+ ConfigSetParams.OVERWRITE, true,
+ ConfigSetParams.CLEANUP, req.getParams().getBool(ConfigSetParams.CLEANUP, false));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = POST,
Review comment:
I don't see the point of the "/files/" component of the path. The files within the configSet are directly in it, so I think it should be that way. I think of this very much like a file in a folder, where the folder is the configSet.
Just checking that we support nested structure within the configSet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org