You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by kpm1985 <gi...@git.apache.org> on 2017/08/01 01:32:17 UTC
[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...
GitHub user kpm1985 opened a pull request:
https://github.com/apache/logging-log4j2/pull/103
LOG4J2-1997 Remove deprecated methods and close resource leaks.
This closes the jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kpm1985/logging-log4j2 mytestbranch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit ca46631fb4e3484641674763119cb1bbc3308821
Author: Kenneth McFarland <ke...@gmail.com>
Date: 2017-08-01T01:30:24Z
Remove deprecated methods and close resource leaks.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 pull request #103: LOG4J2-1997 Remove deprecated methods and ...
Posted by kpm1985 <gi...@git.apache.org>.
Github user kpm1985 closed the pull request at:
https://github.com/apache/logging-log4j2/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #103: LOG4J2-1997 Remove deprecated methods and close r...
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/103
The resources are still leaking if the tests fail midway through a method. How about using try-with-resources clauses?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---