You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "impactCn (via GitHub)" <gi...@apache.org> on 2023/11/13 08:27:07 UTC
[PR] fix: plugin of after lose [shenyu]
impactCn opened a new pull request, #5296:
URL: https://github.com/apache/shenyu/pull/5296
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin of after lose [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind commented on PR #5296:
URL: https://github.com/apache/shenyu/pull/5296#issuecomment-1923382576
fix it in #5432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin of after lose [shenyu]
Posted by "moremind (via GitHub)" <gi...@apache.org>.
moremind closed pull request #5296: fix: plugin of after lose
URL: https://github.com/apache/shenyu/pull/5296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: plugin of after lose [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5296:
URL: https://github.com/apache/shenyu/pull/5296#issuecomment-1807688754
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5296](https://app.codecov.io/gh/apache/shenyu/pull/5296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cee38bf) into [master](https://app.codecov.io/gh/apache/shenyu/commit/be60ba24051c5dbaa1fd5d0510f4c12af2a61787?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (be60ba2) will **decrease** coverage by `0.04%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head cee38bf differs from pull request most recent head 02dce19. Consider uploading reports for the commit 02dce19 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5296 +/- ##
============================================
- Coverage 61.66% 61.62% -0.04%
+ Complexity 8803 8798 -5
============================================
Files 1263 1263
Lines 38873 38870 -3
Branches 3709 3705 -4
============================================
- Hits 23971 23955 -16
- Misses 12786 12796 +10
- Partials 2116 2119 +3
```
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rg/apache/shenyu/web/handler/ShenyuWebHandler.java](https://app.codecov.io/gh/apache/shenyu/pull/5296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9oYW5kbGVyL1NoZW55dVdlYkhhbmRsZXIuamF2YQ==) | `89.15% <100.00%> (-0.26%)` | :arrow_down: |
... and [9 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/5296/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org