You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Igor Kryvenko <kr...@gmail.com> on 2018/10/24 20:06:56 UTC

Review Request 69145: OrcInputFormat.SplitGenerator.callInternal() can be optimized

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69145/
-----------------------------------------------------------

Review request for hive and Eugene Koifman.


Bugs: HIVE-14516
    https://issues.apache.org/jira/browse/HIVE-14516


Repository: hive-git


Description
-------

callIntenal() has 
// We can't eliminate stripes if there are deltas because the
// deltas may change the rows making them match the predicate.

but in Acid 2.0, the deltas only have delete events thus eliminating stripes from "base" of split should be safe.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 25b2d483d7 


Diff: https://reviews.apache.org/r/69145/diff/1/


Testing
-------


Thanks,

Igor Kryvenko