[GitHub] [tvm] masahi commented on a diff in pull request #10801: [BYOC][ACL] Fix list is not supported as an input node

[GitBox <gi...@apache.org>]

masahi commented on code in PR #10801:
URL: https://github.com/apache/tvm/pull/10801#discussion_r849240103


##########
python/tvm/relay/op/contrib/arm_compute_lib.py:
##########
@@ -52,11 +56,15 @@ def partition_for_arm_compute_lib(mod, params=None, **opts):
         The module to run passes on.
     params : Optional[Dict[str, NDArray]]
         Constant input parameters.
+    offload_concat : Optional[bool]
+        Whether offload concatenate
 
     Returns
     -------
     ret : annotated and partitioned module.
     """
+    global offload_concat_

Review Comment:
   Rather than using a global var, can we make use of `arm_compute_lib_pattern_table`? https://github.com/apache/tvm/blob/8a0472fd3e3138ff17391b449cc02de3ab2c4207/python/tvm/relay/op/contrib/arm_compute_lib.py#L131
   
   i.e. register `concat` pattern if `offload_concat == `.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org